Abstract discovery endpoints #423
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mamoonraja
reviewed
Jul 12, 2018
| Log.Debug("TestDiscovery.RunTest()", "Discovery examples complete."); | ||
| } | ||
|
|
||
…-developer-cloud/unity-sdk into 4933-abstract-discovery-endpoints
|
got it - autoformatted examples and tests |
mamoonraja
reviewed
Jul 12, 2018
| @@ -83,6 +83,12 @@ public class ExampleDiscovery : MonoBehaviour | |||
| private bool _readyToContinue = false; | |||
| private float _waitTime = 10f; | |||
|
|
|||
| private bool _listCredentialsTested = false; | |||
There was a problem hiding this comment.
just a minor thing but was thinking we should have variable names consistent. i.e, _getCredentialTested should be like others i.e, _getCredentialsTested
mamoonraja
approved these changes
Jul 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request adds support for Discovery Credentials methods. All methods are supported in the SDK except for the
updateoperation since Unity www does not support put operations.