Skip to content

Abstract discovery endpoints #423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Jul 12, 2018
Merged

Abstract discovery endpoints #423

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
8b249a6
feat(datamodel): Add datamodels for Credentials operations
mediumTaj Jul 11, 2018
d6534e2
refactor(datamodel): Update enums in datamodel
mediumTaj Jul 11, 2018
d4c7a29
refactor: autoformat Discovery.cs
mediumTaj Jul 11, 2018
40e2e3c
feat(discovery): abstract Credentials operations
mediumTaj Jul 11, 2018
74afbeb
feat(examples): add examples for new Discovery Credentials endpoints
mediumTaj Jul 11, 2018
a539d72
test(discovery): add integration tests for Credentials endpoints
mediumTaj Jul 12, 2018
82dd5c4
Merge branch 'develop' into 4933-abstract-discovery-endpoints
mamoonraja Jul 12, 2018
6151d7b
Merge branch 'develop' into 4933-abstract-discovery-endpoints
mediumTaj Jul 12, 2018
5a97842
refactor(examples):autoformat discovery examples
mediumTaj Jul 12, 2018
9d8eb04
refactor(tests): autoformat discovery tests
mediumTaj Jul 12, 2018
46d1cd1
Merge branch '4933-abstract-discovery-endpoints' of github.com:watson…
mediumTaj Jul 12, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
79 changes: 78 additions & 1 deletion Examples/ServiceExamples/Scripts/ExampleDiscovery.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,12 @@ public class ExampleDiscovery : MonoBehaviour
private bool _readyToContinue = false;
private float _waitTime = 10f;

private bool _listCredentialsTested = false;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a minor thing but was thinking we should have variable names consistent. i.e, _getCredentialTested should be like others i.e, _getCredentialsTested

private bool _createCredentialsTested = false;
private bool _getCredentialTested = false;
private bool _deleteCredentialsTested = false;
private string _createdCredentialId = null;

private void Start()
{
LogSystem.InstallDefaultReactors();
Expand Down Expand Up @@ -285,6 +291,44 @@ private IEnumerator Examples()
while (!_isEnvironmentReady)
yield return null;

// List Credentials
Log.Debug("TestDiscovery.RunTest()", "Attempting to list credentials");
_service.ListCredentials(OnListCredentials, OnFail, _environmentId);
while (!_listCredentialsTested)
yield return null;

// Create Credentials
Log.Debug("TestDiscovery.RunTest()", "Attempting to create credentials");
SourceCredentials credentialsParameter = new SourceCredentials()
{
SourceType = SourceCredentials.SourceTypeEnum.box,
CredentialDetails = new CredentialDetails()
{
CredentialType = CredentialDetails.CredentialTypeEnum.oauth2,
EnterpriseId = "myEnterpriseId",
ClientId = "myClientId",
ClientSecret = "myClientSecret",
PublicKeyId = "myPublicIdKey",
Passphrase = "myPassphrase",
PrivateKey = "myPrivateKey"
}
};
_service.CreateCredentials(OnCreateCredentials, OnFail, _environmentId, credentialsParameter);
while (!_createCredentialsTested)
yield return null;

// Get Credential
Log.Debug("TestDiscovery.RunTest()", "Attempting to get credential");
_service.GetCredential(OnGetCredential, OnFail, _environmentId, _createdCredentialId);
while (!_getCredentialTested)
yield return null;

// DeleteCredential
Log.Debug("TestDiscovery.RunTest()", "Attempting to delete credential");
_service.DeleteCredentials(OnDeleteCredentials, OnFail, _environmentId, _createdCredentialId);
while (!_deleteCredentialsTested)
yield return null;

Log.Debug("TestDiscovery.RunTest()", "Discovery examples complete.");
}

Expand Down Expand Up @@ -327,13 +371,22 @@ private IEnumerator Delay(float waitTime)
private void OnGetEnvironments(GetEnvironmentsResponse resp, Dictionary<string, object> customData)
{
Log.Debug("ExampleDiscovery.OnGetEnvironments()", "Discovery - GetEnvironments Response: {0}", customData["json"].ToString());

foreach (var environment in resp.environments)
{
if (environment.read_only == false)
{
Log.Debug("ExampleDiscovery.OnGetEnvironments()", "setting environment to {0}", environment.environment_id);
_environmentId = environment.environment_id;
}
}

_getEnvironmentsTested = true;
}

private void OnGetEnvironment(Environment resp, Dictionary<string, object> customData)
{
Log.Debug("ExampleDiscovery.OnGetEnvironment()", "Discovery - GetEnvironment Response: {0}", customData["json"].ToString());
_environmentId = resp.environment_id;
_getEnvironmentTested = true;
}

Expand Down Expand Up @@ -437,6 +490,30 @@ private void OnQuery(QueryResponse resp, Dictionary<string, object> customData)
_queryTested = true;
}

private void OnListCredentials(CredentialsList response, Dictionary<string, object> customData)
{
Log.Debug("ExampleDiscovery.OnListCredentials()", "Response: {0}", customData["json"].ToString());
_listCredentialsTested = true;
}
private void OnCreateCredentials(SourceCredentials response, Dictionary<string, object> customData)
{
Log.Debug("ExampleDiscovery.OnCreateCredentials()", "Response: {0}", customData["json"].ToString());
_createdCredentialId = response.CredentialId;
_createCredentialsTested = true;
}

private void OnGetCredential(SourceCredentials response, Dictionary<string, object> customData)
{
Log.Debug("ExampleDiscovery.OnGetCredential()", "Response: {0}", customData["json"].ToString());
_getCredentialTested = true;
}

private void OnDeleteCredentials(DeleteCredentials response, Dictionary<string, object> customData)
{
Log.Debug("ExampleDiscovery.OnDeleteCredentials()", "Response: {0}", customData["json"].ToString());
_deleteCredentialsTested = true;
}

private void OnFail(RESTConnector.Error error, Dictionary<string, object> customData)
{
Log.Error("ExampleDiscovery.OnFail()", "Error received: {0}", error.ToString());
Expand Down
Loading