Skip to content

feat: support "umd" format #299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 17, 2024
Merged

feat: support "umd" format #299

merged 5 commits into from
Oct 17, 2024

Conversation

fi3ework
Copy link
Member

@fi3ework fi3ework commented Oct 16, 2024

Summary

TODO:

umdModuleName lacks some advanced features:

  1. non string type
  2. auto transform to camel case

We might implement them after understand why they're supported in https://modernjs.dev/module-tools/api/config/build-config.html#umdglobals.


update:

  1. Don't need to support auto transform to camel case, it was a limitation when implement with swc.
  2. non string type might support it.

Related Links

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copy link

netlify bot commented Oct 16, 2024

Deploy Preview for rslib ready!

Name Link
🔨 Latest commit 4532096
🔍 Latest deploy log https://app.netlify.com/sites/rslib/deploys/670f89065ea9ca0008a8b8f1
😎 Deploy Preview https://deploy-preview-299--rslib.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codspeed-hq bot commented Oct 16, 2024

CodSpeed Performance Report

Merging #299 will create unknown performance changes

Comparing umd (e9b87d3) with main (96f5983)

Summary

🆕 4 new benchmarks
⁉️ 3 (👁 3) dropped benchmarks

Benchmarks breakdown

Benchmark main umd Change
🆕 examples/express-plugin N/A 107 ms N/A
🆕 examples/react-component-bundle N/A 156.6 ms N/A
🆕 examples/react-component-bundle-false N/A 183.1 ms N/A
🆕 examples/react-component-umd N/A 162.9 ms N/A
👁 examples/express-plugin 106 ms N/A N/A
👁 examples/react-component-bundle 155.3 ms N/A N/A
👁 examples/react-component-bundle-false 169.6 ms N/A N/A

@fi3ework
Copy link
Member Author

I think I need to split the UMD config from the current example as it will mix the benchmarks all together.

@fi3ework fi3ework force-pushed the umd branch 2 times, most recently from 4532096 to 4c12b6f Compare October 16, 2024 09:46
@Timeless0911 Timeless0911 merged commit f4bb341 into main Oct 17, 2024
18 checks passed
@Timeless0911 Timeless0911 deleted the umd branch October 17, 2024 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants