use res.send instead of res.end to enable etag. #27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
use res.send instead of res.end to enable etag.
|
👍 |
sokra
added a commit
that referenced
this pull request
Jan 12, 2016
use res.send instead of res.end to enable etag.
|
Thanks |
|
This breaks using the dev server as a middleware for var config = {/*...*/}
var server = require('browser-sync');
var compiler = webpack(config);
serve({
port: process.env.PORT || 3000,
open: false,
server: {baseDir: 'server/dist/'},
middleware: [
webpackDevMiddleware(compiler, {
stats: {
chunks: false,
modules: false,
},
publicPath: config.output.publicPath,
}),
],
});It worked fine with |
|
I get the same error using gulp-connect |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
use res.send instead of res.end to enable etag.