refactor: log publicPath info #883
Conversation
Codecov Report
@@ Coverage Diff @@
## master #883 +/- ##
=======================================
Coverage 98.58% 98.59%
=======================================
Files 10 10
Lines 282 284 +2
Branches 99 101 +2
=======================================
+ Hits 278 280 +2
Misses 4 4
Continue to review full report at Codecov.
|
| @@ -12,6 +12,10 @@ export default function getPaths(context) { | |||
| ? compilation.getPath(compilation.outputOptions.publicPath) | |||
| : ''; | |||
|
|
|||
| if (publicPath) { | |||
| context.logger.info(`webpack output is served from "${publicPath === 'auto' ? '/' : publicPath}" URL`); | |||
| } | |||
There was a problem hiding this comment.
It will be spam on each request, we need move it only on constructor place
|
I was wrong, I think we don't need this logging, it is weird, because |
|
So we just remove this logging from dev-server ? |
|
Yes, I think most of developers see these messages like spam, so let's remove it, I don't think we create problem here removing this, also plugins can change publicPath too, so we know real publicPath only after compilation |
|
Makes sense 👍 |
This PR contains a:
Motivation / Use-Case
For webpack/webpack-dev-server#3218
Breaking Changes
Maybe
Additional Info
None