Skip to content

refactor: remove publicPath log #3218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 28, 2021
Merged

refactor: remove publicPath log #3218

merged 2 commits into from
Apr 28, 2021

Conversation

snitin315
Copy link
Member

@snitin315 snitin315 commented Apr 23, 2021

  • This is a bugfix
  • This is a feature
  • This is a code refactor
  • This is a test update
  • This is a docs update
  • This is a metadata update

For Bugs and Features; did you add new tests?

updated existing tests.

Motivation / Use-Case

Move this log to webpack-dev-middleware.

Breaking Changes

Additional Info

Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Le't firstly improve this in webpack-dev-middleware, then I do release, then we update our version and remove it from here

Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@snitin315 Can you fix tests?

@codecov
Copy link

codecov bot commented Apr 27, 2021

Codecov Report

Merging #3218 (35873bb) into master (d2b8837) will increase coverage by 0.21%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3218      +/-   ##
==========================================
+ Coverage   95.19%   95.41%   +0.21%     
==========================================
  Files          37       37              
  Lines        1248     1242       -6     
  Branches      352      347       -5     
==========================================
- Hits         1188     1185       -3     
+ Misses         54       51       -3     
  Partials        6        6              
Impacted Files Coverage Δ
lib/Server.js 95.10% <ø> (+0.54%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d2b8837...35873bb. Read the comment docs.

@snitin315
Copy link
Member Author

@alexander-akait done 👍🏻

Copy link
Member

@anshumanv anshumanv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great 👍

@snitin315 snitin315 marked this pull request as ready for review April 27, 2021 09:11
@alexander-akait alexander-akait merged commit bc63a71 into master Apr 28, 2021
@alexander-akait alexander-akait deleted the public-path branch April 28, 2021 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants