-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
refactor: remove publicPath log #3218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Le't firstly improve this in webpack-dev-middleware
, then I do release, then we update our version and remove it from here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@snitin315 Can you fix tests?
Codecov Report
@@ Coverage Diff @@
## master #3218 +/- ##
==========================================
+ Coverage 95.19% 95.41% +0.21%
==========================================
Files 37 37
Lines 1248 1242 -6
Branches 352 347 -5
==========================================
- Hits 1188 1185 -3
+ Misses 54 51 -3
Partials 6 6
Continue to review full report at Codecov.
|
@alexander-akait done 👍🏻 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great 👍
For Bugs and Features; did you add new tests?
updated existing tests.
Motivation / Use-Case
Move this log to webpack-dev-middleware.
Breaking Changes
Additional Info