feat: add --client-need-client-entry and --client-need-hot-entry

[snitin315]

• This is a bugfix
• This is a feature
• This is a code refactor
• This is a test update
• This is a docs update
• This is a metadata update

For Bugs and Features; did you add new tests?

Yes.

Motivation / Use-Case

Addded -

• --client-need-client-entry
• --no-client-need-client-entry
• --client-need-hot-entry
• --no-client-need-hot-entry

Breaking Changes

None

Additional Info

No

[snitin315]

Maybe we need a better name, double client can be confusing.

[alexander-akait]

Yep, good catch I will think about it

[snitin315]

Maybe:

client: {
   appendDefaultEntries: true,
   appendHotEntries: true
}

[alexander-akait]

hm, give me time to think about these options, maybe we need { client: (entry) => { return clientOption; } }, so you will setup hot/client entry for multiple entrypoints

[codecov]

Codecov Report

Merging #3228 (948b804) into master (1997a6e) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #3228   +/-   ##
=======================================
  Coverage   95.19%   95.19%           
=======================================
  Files          37       37           
  Lines        1248     1248           
  Branches      352      352           
=======================================
  Hits         1188     1188           
  Misses         54       54           
  Partials        6        6           

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1997a6e...948b804. Read the comment docs.

[alexander-akait]

@snitin315 I found solution:

• let's rename needHotEntry -> hotEntry: boolean (--client-hot-entry), default value const hotEntry = options.client.hotEntry || options.hot
• let's remove needClientEntry in favor client: boolean | ClientOptions | function(entryName): ClientOptions, so you can disable hotEntry or whole client by entries using function (--client and --no-client)

Maybe in future we will allow to write to only specific client (we already have this information internally, nobody ask this, so let's postpone)

[snitin315]

Nice solution. I will update 👍