-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
feat: add client.hotEntry
and --client-hot-entry
#3294
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3294 +/- ##
=======================================
Coverage 95.54% 95.55%
=======================================
Files 34 34
Lines 1258 1260 +2
Branches 356 357 +1
=======================================
+ Hits 1202 1204 +2
Misses 52 52
Partials 4 4
Continue to review full report at Codecov.
|
@snitin315 Can you rebase? |
6f8c132
to
094f7ed
Compare
@alexander-akait Done ✅ |
@snitin315 Let's do the next PR ⭐ |
For Bugs and Features; did you add new tests?
Yes
Motivation / Use-Case
Fix #3228
I want to split #3228 (comment) into multiple commit/PRs
This PR - rename
needHotEntry -> hotEntry: boolean (--client-hot-entry)
, default valueconst hotEntry = options.client.hotEntry || options.hot
Next PR - remove needClientEntry in favor
client: boolean | ClientOptions | function(entryName): ClientOptions
, so you can disablehotEntry
or whole client by entries using function (--client
and--no-client
)Breaking Changes
BREAKING CHANGE:
client.needHotEntry
was removed in favor ofclient.hotEntry
Additional Info
No