Skip to content

feat: add client.hotEntry and --client-hot-entry #3294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
May 15, 2021

Conversation

snitin315
Copy link
Member

  • This is a bugfix
  • This is a feature
  • This is a code refactor
  • This is a test update
  • This is a docs update
  • This is a metadata update

For Bugs and Features; did you add new tests?

Yes

Motivation / Use-Case

Fix #3228

I want to split #3228 (comment) into multiple commit/PRs

  • This PR - rename needHotEntry -> hotEntry: boolean (--client-hot-entry), default value const hotEntry = options.client.hotEntry || options.hot

  • Next PR - remove needClientEntry in favor client: boolean | ClientOptions | function(entryName): ClientOptions, so you can disable hotEntry or whole client by entries using function (--client and --no-client)

Breaking Changes

BREAKING CHANGE: client.needHotEntry was removed in favor of client.hotEntry

Additional Info

No

@codecov
Copy link

codecov bot commented May 14, 2021

Codecov Report

Merging #3294 (094f7ed) into master (5f657a2) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3294   +/-   ##
=======================================
  Coverage   95.54%   95.55%           
=======================================
  Files          34       34           
  Lines        1258     1260    +2     
  Branches      356      357    +1     
=======================================
+ Hits         1202     1204    +2     
  Misses         52       52           
  Partials        4        4           
Impacted Files Coverage Δ
lib/utils/DevServerPlugin.js 98.82% <100.00%> (ø)
lib/utils/normalizeOptions.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5f657a2...094f7ed. Read the comment docs.

@alexander-akait
Copy link
Member

@snitin315 Can you rebase?

@snitin315
Copy link
Member Author

@alexander-akait Done ✅

@alexander-akait alexander-akait merged commit c0b073d into master May 15, 2021
@alexander-akait alexander-akait deleted the client-hot-entry branch May 15, 2021 16:13
@alexander-akait
Copy link
Member

@snitin315 Let's do the next PR ⭐

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants