refactor: avoid new public options on class

[snitin315]

• This is a bugfix
• This is a feature
• This is a code refactor
• This is a test update
• This is a docs update
• This is a metadata update

For Bugs and Features; did you add new tests?

Motivation / Use-Case

rely on this.options.host

Breaking Changes

None

Additional Info

No

[codecov]

Codecov Report

Merging #3261 (d78b8f9) into master (9801377) will increase coverage by 0.13%.
The diff coverage is 86.84%.

@@            Coverage Diff             @@
##           master    #3261      +/-   ##
==========================================
+ Coverage   95.55%   95.68%   +0.13%     
==========================================
  Files          34       34              
  Lines        1260     1276      +16     
  Branches      357      366       +9     
==========================================
+ Hits         1204     1221      +17     
+ Misses         52       51       -1     
  Partials        4        4              

Impacted Files	Coverage Δ
lib/Server.js	96.03% <86.84%> (+0.30%)	⬆️
lib/utils/normalizeOptions.js	100.00% <0.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9801377...d78b8f9. Read the comment docs.

[alexander-akait]

Good job, ideally we should add tests:

• const devServer = new DevServer({ host: '192.168.0.2' }); devServer.listen(80, '127.0.0.1'); and throw an error like we do with the port option
• const devServer = new DevServer({ host: '192.168.0.2' }); devServer.listen(80); should work and listen 192.168.0.2

Also I think we should support signatures like in server.listen https://nodejs.org/api/net.html#net_server_listen (except), but we can do it in separate PR

[snitin315]

I will update 👍

[snitin315]

const devServer = new DevServer({ host: '192.168.0.2' }); devServer.listen(80, '127.0.0.1'); and throw an error like we do with the port option

In the case of port we are just logging a warning, should we throw an error instead?

webpack-dev-server/lib/Server.js

Lines 764 to 768 in 297a649

	if (typeof port !== 'undefined' && port !== this.options.port) {
	this.logger.warn(
	'The port specified in options and the port passed as an argument is different.'
	);
	}

[alexander-akait]

Better warning here

[snitin315]

I will fix CI in near future

[alexander-akait]

I will test and review it in near future

[alexander-akait]

@snitin315 need rebase too

[snitin315]

Unfortunately I'm off my system, it's already night here. I will rebase in near future.

[snitin315]

Done ✅