refactor: change order of params for Server #3273
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3273 +/- ##
=======================================
Coverage 95.39% 95.40%
=======================================
Files 34 34
Lines 1239 1241 +2
Branches 353 354 +1
=======================================
+ Hits 1182 1184 +2
Misses 51 51
Partials 6 6
Continue to review full report at Codecov.
|
Hey! No need to thank as such but appreciated 😄. |
rishabh3112
requested review from
alexander-akait,
hiroppy,
knagaitsev and
snitin315
as code owners
6 tasks
alexander-akait
previously approved these changes
May 12, 2021
Nothing is changed in this PR for multi-compilers though, will add similar test for multi-compiler too anyway. EDIT: Done 👍🏽 |
alexander-akait
approved these changes
May 13, 2021
|
Thanks |
|
Now we can continue development dev server as plugin and don't worry about breaking change for v4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For Bugs and Features; did you add new tests?
Will update tests accordingly
Motivation / Use-Case
We are moving to plugin interface for the server. The ideal signature for that would be
constructor(options={})but we need compiler in params as well for backward compatibility. For that reason, this PR aims to change the order of params so that plugin implementation can ignore compiler param.Breaking Changes
Yes, we will need to fix this in serve package after patch release here
Additional Info
https://github.com/webpack/webpack-dev-server/pull/3251/files#r629851714