-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
feat: implement dev server as plugin #3251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3251 +/- ##
==========================================
- Coverage 95.72% 95.31% -0.41%
==========================================
Files 33 33
Lines 1309 1259 -50
Branches 388 360 -28
==========================================
- Hits 1253 1200 -53
- Misses 52 55 +3
Partials 4 4
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Logic should be in apply
function here https://github.com/webpack/webpack-dev-server/blob/master/lib/Server.js, no need to duplicate this, all method already exists in server
Okay, I will make changes inplace then. I thought of doing it seperately to avoid breaking changes in release. |
Status
|
@alexander-akait what should I do next in this PR? I am done on my end 😅 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we avoid a lot of change, maybe better create a new PR
Yup, will create a new PR for this now. |
For Bugs and Features; did you add new tests?
Motivation / Use-Case
The Dev Server should be implemented as a plugin for long run. This would simplify implementation of
webpack serve
as will give user more flexibility in multicompiler case.The current implementation code present in
DevServerPlugin.js
implements few parts but still relies onServer.js
to be applied.I am currently implementing it separately at
WebpackDevServerPlugin.js
to simplify testing. Later on we will export only this plugin instead onServe.js
.Breaking Changes
Yes, it would be a breaking change.
Additional Info
@alexander-akait suggested this feature. Rest, we can chat on this PR.