-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Refactor servers #3446
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor servers #3446
Conversation
b122e1c
to
149ebab
Compare
Codecov Report
@@ Coverage Diff @@
## master #3446 +/- ##
==========================================
+ Coverage 87.45% 94.84% +7.38%
==========================================
Files 9 34 +25
Lines 598 1358 +760
Branches 180 401 +221
==========================================
+ Hits 523 1288 +765
- Misses 63 65 +2
+ Partials 12 5 -7
Continue to review full report at Codecov.
|
@snitin315 @anshumanv this PR should fix tests and reduce freezing our tests, sometimes jest do not throw an error in our tests, WIP on this too, and then we will update just and return to stale PRs |
Still rare freeze, let's fix them here #3448 |
For Bugs and Features; did you add new tests?
I will remove
--forceExit
from jest CLI, because we have bug so we have this stuffMotivation / Use-Case
fix closing web socket server
Breaking Changes
No
Additional Info
no