Skip to content

Refactor servers #3446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Jun 16, 2021
Merged

Refactor servers #3446

merged 14 commits into from
Jun 16, 2021

Conversation

alexander-akait
Copy link
Member

  • This is a bugfix
  • This is a feature
  • This is a code refactor
  • This is a test update
  • This is a docs update
  • This is a metadata update

For Bugs and Features; did you add new tests?

I will remove --forceExit from jest CLI, because we have bug so we have this stuff

Motivation / Use-Case

fix closing web socket server

Breaking Changes

No

Additional Info

no

@codecov
Copy link

codecov bot commented Jun 16, 2021

Codecov Report

Merging #3446 (50cba19) into master (003c927) will increase coverage by 7.38%.
The diff coverage is 95.05%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3446      +/-   ##
==========================================
+ Coverage   87.45%   94.84%   +7.38%     
==========================================
  Files           9       34      +25     
  Lines         598     1358     +760     
  Branches      180      401     +221     
==========================================
+ Hits          523     1288     +765     
- Misses         63       65       +2     
+ Partials       12        5       -7     
Impacted Files Coverage Δ
lib/utils/findCacheDir.js 61.90% <61.90%> (ø)
client-src/utils/sendMessage.js 85.71% <85.71%> (ø)
client-src/utils/reloadApp.js 86.95% <86.95%> (ø)
lib/utils/getCertificate.js 88.46% <88.46%> (ø)
lib/utils/getSocketServerImplementation.js 90.47% <90.47%> (ø)
lib/servers/SockJSServer.js 90.69% <90.69%> (ø)
lib/utils/setupExitSignals.js 90.90% <90.90%> (ø)
client-src/index.js 91.07% <91.07%> (ø)
lib/servers/WebsocketServer.js 94.73% <94.73%> (ø)
lib/Server.js 95.02% <95.59%> (+11.57%) ⬆️
... and 55 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f7e922d...50cba19. Read the comment docs.

@alexander-akait
Copy link
Member Author

alexander-akait commented Jun 16, 2021

@snitin315 @anshumanv this PR should fix tests and reduce freezing our tests, sometimes jest do not throw an error in our tests, WIP on this too, and then we will update just and return to stale PRs

@alexander-akait
Copy link
Member Author

Still rare freeze, let's fix them here #3448

@alexander-akait alexander-akait merged commit bc8328a into master Jun 16, 2021
@alexander-akait alexander-akait deleted the refactor-servers branch June 16, 2021 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant