test: fix test freeze #3448
test: fix test freeze #3448
Conversation
alexander-akait
requested review from
anshumanv,
hiroppy,
knagaitsev and
snitin315
as code owners
alexander-akait
force-pushed
the
jest-do-not-freeze-on-error
branch
from
8ad7e7b to
f14897b
Compare
| @@ -1,124 +0,0 @@ | |||
| 'use strict'; | |||
There was a problem hiding this comment.
We don't need this stupid test anymore, we have good e2e tests right now https://github.com/webpack/webpack-dev-server/blob/master/test/e2e/hot-and-live-reload.test.js
| @@ -389,7 +389,7 @@ describe('webSocketServer', () => { | |||
| }); | |||
| }); | |||
|
|
|||
| describe('with a bad host header', () => { | |||
| describe.skip('with a bad host header', () => { | |||
There was a problem hiding this comment.
Ideally we should remove them in favor e2e test, I will add late them
|
Should be fine now, in the next PR I will remove |
Codecov Report
@@ Coverage Diff @@
## master #3448 +/- ##
==========================================
- Coverage 95.02% 94.77% -0.26%
==========================================
Files 34 34
Lines 1346 1358 +12
Branches 397 401 +4
==========================================
+ Hits 1279 1287 +8
- Misses 62 66 +4
Partials 5 5
Continue to review full report at Codecov.
|
|
Let's merge as is and remove |
For Bugs and Features; did you add new tests?
it is tests
Motivation / Use-Case
fix freeze and throw an good error if problem happens
Breaking Changes
No
Additional Info
fixes #3399