-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
test: use latest API methods #3617
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3617 +/- ##
==========================================
+ Coverage 93.55% 93.70% +0.15%
==========================================
Files 15 15
Lines 1318 1318
Branches 456 456
==========================================
+ Hits 1233 1235 +2
+ Misses 78 76 -2
Partials 7 7
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is special test for old API, because we can't break it
Are there any other instances we want to update? if not, I think we can close it. |
Need check please run test locally, ideally we should have only one test for old API (it is this test) |
I found a few instances in Server.test.js - webpack-dev-server/test/server/Server.test.js Lines 65 to 71 in 974ce25
|
Feel free to fix them |
I will update |
4d1af35
to
079acd3
Compare
For Bugs and Features; did you add new tests?
Motivation / Use-Case
use latest API methods
Breaking Changes
None
Additional Info
No