Skip to content

test: use latest API methods #3617

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 19, 2021
Merged

test: use latest API methods #3617

merged 1 commit into from
Aug 19, 2021

Conversation

snitin315
Copy link
Member

  • This is a bugfix
  • This is a feature
  • This is a code refactor
  • This is a test update
  • This is a docs update
  • This is a metadata update

For Bugs and Features; did you add new tests?

Motivation / Use-Case

use latest API methods

Breaking Changes

None

Additional Info

No

@codecov
Copy link

codecov bot commented Aug 13, 2021

Codecov Report

Merging #3617 (079acd3) into master (ad0cdb4) will increase coverage by 0.15%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3617      +/-   ##
==========================================
+ Coverage   93.55%   93.70%   +0.15%     
==========================================
  Files          15       15              
  Lines        1318     1318              
  Branches      456      456              
==========================================
+ Hits         1233     1235       +2     
+ Misses         78       76       -2     
  Partials        7        7              
Impacted Files Coverage Δ
lib/servers/WebsocketServer.js 97.14% <0.00%> (+5.71%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ad0cdb4...079acd3. Read the comment docs.

Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is special test for old API, because we can't break it

@snitin315
Copy link
Member Author

Are there any other instances we want to update? if not, I think we can close it.

@alexander-akait
Copy link
Member

Need check please run test locally, ideally we should have only one test for old API (it is this test)

@snitin315
Copy link
Member Author

I found a few instances in Server.test.js -

server.listen(port, "localhost", (error) => {
if (error) {
throw error;
}
getEntries(server);
});

@alexander-akait
Copy link
Member

Feel free to fix them

@snitin315
Copy link
Member Author

I will update

@alexander-akait alexander-akait merged commit 76112b7 into master Aug 19, 2021
@alexander-akait alexander-akait deleted the test-use-new-api branch August 19, 2021 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants