Skip to content

test: use latest API methods #3617

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 19, 2021
Merged

test: use latest API methods #3617

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion test/e2e/multi-compiler.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,6 @@ describe("Multi compiler", () => {
expect(pageErrors).toMatchSnapshot("page errors");

await browser.close();
await server.close();
await server.stop();
});
});
4 changes: 2 additions & 2 deletions test/e2e/universal-compiler.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ describe("Universal compiler", () => {
expect(pageErrors).toMatchSnapshot("page errors");

await browser.close();
await server.close();
await server.stop();
});

it("server bundle should NOT have the inlined the client runtime", async () => {
Expand Down Expand Up @@ -96,6 +96,6 @@ describe("Universal compiler", () => {
expect(pageErrors).toMatchSnapshot("page errors");

await browser.close();
await server.close();
await server.stop();
});
});
14 changes: 6 additions & 8 deletions test/server/Server.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,12 +57,10 @@ describe("Server", () => {
compiler.hooks.done.tap("webpack-dev-server", () => {
expect(entries).toMatchSnapshot();

server.close(() => {
done();
});
server.stopCallback(done);
});

server.listen(port, "localhost", (error) => {
server.startCallback((error) => {
if (error) {
throw error;
}
Expand All @@ -78,10 +76,10 @@ describe("Server", () => {
compiler.hooks.done.tap("webpack-dev-server", () => {
expect(entries).toMatchSnapshot();

server.close(done);
server.stopCallback(done);
});

server.listen(port, "localhost", (error) => {
server.startCallback((error) => {
if (error) {
throw error;
}
Expand All @@ -105,10 +103,10 @@ describe("Server", () => {
compiler.hooks.done.tap("webpack-dev-server", () => {
expect(entries).toMatchSnapshot("oldparam");

server.close(done);
server.stopCallback(done);
});

server.listen(port, "localhost", (error) => {
server.startCallback((error) => {
if (error) {
throw error;
}
Expand Down