Skip to content

refactor: added additional entries helper #3714

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Aug 24, 2021

Conversation

alexander-akait
Copy link
Member

@alexander-akait alexander-akait commented Aug 21, 2021

  • This is a bugfix
  • This is a feature
  • This is a code refactor
  • This is a test update
  • This is a docs update
  • This is a metadata update

For Bugs and Features; did you add new tests?

Yes

Motivation / Use-Case

fix #3698 + refactor our code for plugin support

Breaking Changes

No

Additional Info

I think it is the last refactor before implement plugin support

@codecov
Copy link

codecov bot commented Aug 21, 2021

Codecov Report

Merging #3714 (db716ee) into master (f563d1d) will decrease coverage by 0.34%.
The diff coverage is 96.36%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3714      +/-   ##
==========================================
- Coverage   93.20%   92.85%   -0.35%     
==========================================
  Files          15       14       -1     
  Lines        1324     1316       -8     
  Branches      458      463       +5     
==========================================
- Hits         1234     1222      -12     
- Misses         83       87       +4     
  Partials        7        7              
Impacted Files Coverage Δ
lib/Server.js 93.81% <96.36%> (+0.22%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f563d1d...db716ee. Read the comment docs.

@alexander-akait
Copy link
Member Author

@snitin315 @anshumanv We should fix our docs here https://webpack.js.org/guides/hot-module-replacement/, example in migration guide

@alexander-akait alexander-akait changed the title feat: added additional entries helper refactor: added additional entries helper Aug 23, 2021
@alexander-akait
Copy link
Member Author

I decide do not add new API, because it is have some limitations and edge cases, better to do it manually, also added small example

@snitin315
Copy link
Member

@snitin315 @anshumanv We should fix our docs here https://webpack.js.org/guides/hot-module-replacement/, example in migration guide

I will update 👍

@snitin315
Copy link
Member

webpack/webpack.js.org#5353

@alexander-akait alexander-akait merged commit 6f33e11 into master Aug 24, 2021
@alexander-akait alexander-akait deleted the feat-add-additional-entires branch August 24, 2021 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Docs]: This migration-v4.md doc not have a change logs for addDevServerEntrypoints
2 participants