Skip to content

Commons - exporting props #1002

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Commons - exporting props #1002

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions src/commons/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,5 +27,14 @@ module.exports = {
},
get withScrollReached() {
return require('./withScrollReached').default;
},
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one is not good..
There's a new temp file commons/new.ts (that will replace commons/index.js eventually)
The typings are already exported there..

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where is the call for the commons/new.ts file? I see only commons/index.js...

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're using it in the components that need these typings..
View, Text, Button.. almost all of them..

get BaseComponentInjectedProps() {
return require('./asBaseComponent').BaseComponentInjectedProps;
},
get ForwardRefInjectedProps() {
return require('./forwardRef').ForwardRefInjectedProps;
},
get ModifiersProps() {
return require('./modifiers').default;
}
};
9 changes: 9 additions & 0 deletions src/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -226,6 +226,15 @@ export default {
get withScrollReached() {
return require('./commons').withScrollReached;
},
get BaseComponentInjectedProps() {
return require('./commons').BaseComponentInjectedProps;
},
get ForwardRefInjectedProps() {
return require('./commons').ForwardRefInjectedProps;
},
get ModifiersProps() {
return require('./commons').default;
},
Comment on lines +229 to +237
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to export the typings in the ts files
generatedTypes/index.d.ts
src/index.ts

Copy link
Collaborator Author

@Inbal-Tish Inbal-Tish Oct 26, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I don't understand what is what with all the fake files... Why they should be exported in generatedTypes/index if these are TS fils? And where all the other commons exports in src/index.ts?


// Helpers
get AvatarHelper() {
Expand Down