Commons - exporting props #1002
Conversation
…ifiersProps (to extract sub-modifiers props, like MarginModifiers).
| @@ -27,5 +27,14 @@ module.exports = { | |||
| }, | |||
| get withScrollReached() { | |||
| return require('./withScrollReached').default; | |||
| }, | |||
There was a problem hiding this comment.
This one is not good..
There's a new temp file commons/new.ts (that will replace commons/index.js eventually)
The typings are already exported there..
There was a problem hiding this comment.
Where is the call for the commons/new.ts file? I see only commons/index.js...
There was a problem hiding this comment.
We're using it in the components that need these typings..
View, Text, Button.. almost all of them..
| get BaseComponentInjectedProps() { | ||
| return require('./commons').BaseComponentInjectedProps; | ||
| }, | ||
| get ForwardRefInjectedProps() { | ||
| return require('./commons').ForwardRefInjectedProps; | ||
| }, | ||
| get ModifiersProps() { | ||
| return require('./commons').default; | ||
| }, |
There was a problem hiding this comment.
You need to export the typings in the ts files
generatedTypes/index.d.ts
src/index.ts
There was a problem hiding this comment.
Sorry, I don't understand what is what with all the fake files... Why they should be exported in generatedTypes/index if these are TS fils? And where all the other commons exports in src/index.ts?
#863 Description
Exporting BaseComponentInjectedProps, ForwardRefInjectedProps and ModifiersProps (to extract sub-modifiers props, like MarginModifiers).
Changelog
Commons - exporting props.