Skip to content

Fix #848 #863

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 29, 2020
Merged

Fix #848 #863

merged 1 commit into from
Jul 29, 2020

Conversation

ethanshar
Copy link
Collaborator

Fix issue with Picker in multi-select mode with custom value object structure
(See use's example in the issue)

  • Added new prop (getItemLabel) for extracting custom label from an item.
  • Fix how we extract the value/label of items in multi select mode

@ethanshar ethanshar requested a review from ArnonZ July 26, 2020 05:36
@ArnonZ ArnonZ merged commit d3af6be into master Jul 29, 2020
@ethanshar ethanshar deleted the fix/Picker_multiSelect branch September 21, 2020 08:03
@Inbal-Tish Inbal-Tish mentioned this pull request Oct 26, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ArnonZ ArnonZ ArnonZ approved these changes

Assignees

@ArnonZ ArnonZ

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ethanshar @ArnonZ