Feat/basic ui #1038
Merged
Feat/basic ui #1038
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lt colors and font
ethanshar
reviewed
Nov 30, 2020
There was a problem hiding this comment.
I wrote in one of the comments about how I approached this component.
Unlike many other components, this one requires a very delicate handling when it comes to performance because the interaction here is very important.
That's the reason I used animated values in many cases.
Animated values are a great way to communicate with the native side without going over the bridge and without updating the state too often.
Go over my comments, we can sync about it if you like.
ethanshar
reviewed
Nov 30, 2020
ethanshar
reviewed
Dec 6, 2020
src/incubator/WheelPicker/Item.tsx
Outdated
Comment on lines
22
to
23
| selectedColor?: string; | ||
| unselectedColor?: string; |
There was a problem hiding this comment.
unselected sounds a little weird..
maybe use activeColor and inactiveColor WDYT?
src/incubator/WheelPicker/index.tsx
Outdated
Comment on lines
30
to
34
| selectedTextColor?: string; | ||
| /** | ||
| * TextStyle for other, non-focused rows | ||
| */ | ||
| unselectedTextStyle?: string; |
There was a problem hiding this comment.
same comment here for the names
src/incubator/WheelPicker/index.tsx
Outdated
Comment on lines
56
to
58
| if (scrollView.current?.getNode()) { | ||
| //@ts-ignore for some reason scrollToOffset isn't recognized | ||
| scrollView.current.getNode().scrollToOffset({offset: index * itemHeight, animated: true}); |
There was a problem hiding this comment.
Would that work?
Suggested change
| if (scrollView.current?.getNode()) { | |
| //@ts-ignore for some reason scrollToOffset isn't recognized | |
| scrollView.current.getNode().scrollToOffset({offset: index * itemHeight, animated: true}); | |
| //@ts-ignore for some reason scrollToOffset isn't recognized | |
| scrollView.current?.getNode()?.scrollToOffset({offset: index * itemHeight, animated: true}); |
Co-authored-by: Ethan Sharabi <[email protected]>
ethanshar
approved these changes
Dec 7, 2020
ethanshar
added a commit
that referenced
this pull request
Dec 7, 2020
* create a customizable WheelPicker * Reset PlaygroundScreen changes * Keep working on WheelPicker (incubator) * Fix TS issues * export WheelPicker in incubator index * Use Flatlist for WheelPicker for better performance when having big lists * Separate to two examples: months and years * Feat/basic ui (#1038) * Removed 'wheel` animation to match the design guidlines + added default colors and font * added text configuration props * on selecting item - wheel will scroll to the right row * added Fader and extract separators * Calculate current active index * added onChange event * Increase visible rows to 5 * change separator color to be visible * added demo code * update reanimated version * types changes * type update * extract logic to it's own type * refactor item center calculation to be based on the offset * update demo screen according to the new api * pass style to item * added unittests to listMiddleIndex calculations * made demo more clear * Update src/incubator/WheelPicker/index.tsx Co-authored-by: Ethan Sharabi <[email protected]> * PR fixes - naming * PR fixes - naming * PR fix - optional chaining Co-authored-by: Ethan Sharabi <[email protected]> Co-authored-by: Mendy Edri <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
UI changes and
active rowlogicChangelog