Skip to content

New custom WheelPicker #740

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Dec 7, 2020
Merged

New custom WheelPicker #740

merged 15 commits into from
Dec 7, 2020

Conversation

ethanshar
Copy link
Collaborator

@ethanshar ethanshar commented Apr 11, 2020

Description

Create new custom wheel picker component (under Incubator)

Changelog

New customizable WheelPicker component (under Incubator)

@ethanshar ethanshar added the WIP label Apr 11, 2020
@ethanshar ethanshar marked this pull request as draft July 19, 2020 07:14
@ethanshar ethanshar changed the title create a customizable WheelPicker New custom WheelPicker Oct 25, 2020
ethanshar and others added 5 commits October 25, 2020 08:31
* Removed 'wheel` animation to match the design guidlines + added default colors and font

* added text configuration props

* on selecting item - wheel will scroll to the right row

* added Fader and extract separators

* Calculate current active index

* added onChange event

* Increase visible rows to 5

* change separator color to be visible

* added demo code

* update reanimated version

* types changes

* type update

* extract logic to it's own type

* refactor item center calculation to be based on the offset

* update demo screen according to the new api

* pass style to item

* added unittests to listMiddleIndex calculations

* made demo more clear

* Update src/incubator/WheelPicker/index.tsx

Co-authored-by: Ethan Sharabi <[email protected]>

* PR fixes - naming

* PR fixes - naming

* PR fix - optional chaining

Co-authored-by: Ethan Sharabi <[email protected]>
@ethanshar ethanshar marked this pull request as ready for review December 7, 2020 15:59
@ethanshar ethanshar merged commit 0fa79e5 into master Dec 7, 2020
@ethanshar ethanshar deleted the feat/WheelPicker branch March 8, 2021 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants