-
Notifications
You must be signed in to change notification settings - Fork 734
New custom WheelPicker #740
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Removed 'wheel` animation to match the design guidlines + added default colors and font * added text configuration props * on selecting item - wheel will scroll to the right row * added Fader and extract separators * Calculate current active index * added onChange event * Increase visible rows to 5 * change separator color to be visible * added demo code * update reanimated version * types changes * type update * extract logic to it's own type * refactor item center calculation to be based on the offset * update demo screen according to the new api * pass style to item * added unittests to listMiddleIndex calculations * made demo more clear * Update src/incubator/WheelPicker/index.tsx Co-authored-by: Ethan Sharabi <[email protected]> * PR fixes - naming * PR fixes - naming * PR fix - optional chaining Co-authored-by: Ethan Sharabi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Create new custom wheel picker component (under Incubator)
Changelog
New customizable WheelPicker component (under Incubator)