Create a middleware TextField migrator #1113
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…extField implementation
|
@ethanshar Don't you want to set up the lint here as well so users can enjoy the auto fix? |
Inbal-Tish
approved these changes
Jan 4, 2021
|
@Inbal-Tish |
I know. I thought we can configure it here as well. |
|
No one is using it in the community.. |
M-i-k-e-l
added a commit
that referenced
this pull request
Jan 6, 2021
…-logic * master: Add missing functionality for Incubator.TextField (#1121) Update all app icons sizes for iOS project Adding 'defaultSource' for image source in case of an error (#1116) DateTimePicker - adding 'headerStyle' prop to adjust iOS dialog header style (#1117) add prepush script Infra/use did update (#1119) SettingsScreen - rename to UNSAFE (#1118) Create a middleware TextField migrator to migrate people to the new TextField implementation (#1113) Fix issue with missing selected indicator in Picker items (#1065) Fix issue for Android on rn63 - when passing null as tintColor to an image, the image is not displayed (#1055) Fix issue #1052 - PickerItem ignore renderItem prop (#1054) Dialog - RN63 broke Modal's onDismiss method, this fixes our API (#1026) pass containerStyle to checkbox when there's no label render checkbox container only if there's label (#1039)
M-i-k-e-l
added a commit
that referenced
this pull request
Jan 14, 2021
* master: (41 commits) Remove animatable from FloatingButton component (#1134) Stop using AnimatableManager in Hint (#1125) Change setTimeout's time from 50 to 100 Update generated types push expo stuff Update wiki links Fix/dialog swiping does not trigger on dialog dismissed (#1093) remove github token Create colors.md CardsScreen - fix backgrounds and remove obsolete examples (#1124) trigger build Add missing functionality for Incubator.TextField (#1121) Update all app icons sizes for iOS project Adding 'defaultSource' for image source in case of an error (#1116) DateTimePicker - adding 'headerStyle' prop to adjust iOS dialog header style (#1117) add prepush script Infra/use did update (#1119) SettingsScreen - rename to UNSAFE (#1118) Create a middleware TextField migrator to migrate people to the new TextField implementation (#1113) Fix lint error ...
M-i-k-e-l
added a commit
that referenced
this pull request
Jan 14, 2021
* master: (41 commits) Remove animatable from FloatingButton component (#1134) Stop using AnimatableManager in Hint (#1125) Change setTimeout's time from 50 to 100 Update generated types push expo stuff Update wiki links Fix/dialog swiping does not trigger on dialog dismissed (#1093) remove github token Create colors.md CardsScreen - fix backgrounds and remove obsolete examples (#1124) trigger build Add missing functionality for Incubator.TextField (#1121) Update all app icons sizes for iOS project Adding 'defaultSource' for image source in case of an error (#1116) DateTimePicker - adding 'headerStyle' prop to adjust iOS dialog header style (#1117) add prepush script Infra/use did update (#1119) SettingsScreen - rename to UNSAFE (#1118) Create a middleware TextField migrator to migrate people to the new TextField implementation (#1113) Fix lint error ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Create TextFieldMigrator to migrate users from the old TextField implementation to the new.
Changelog
Start migrating to our new TextField implementation by passing the
migrateprop.