Stop using AnimatableManager in Hint #1125
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Inbal-Tish
reviewed
Jan 14, 2021
| animation={shownUp ? AnimatableManager.animations.hintAppearUp : AnimatableManager.animations.hintAppearDown} | ||
| duration={200} | ||
| <View | ||
| animated |
There was a problem hiding this comment.
how do you control the type of animation to apply on the View?
There was a problem hiding this comment.
What do you mean?
There was a problem hiding this comment.
Got it. getHintAnimatedStyle
There was a problem hiding this comment.
The default one.
Users won't be able to configure it now.
I don't thing people were aware of that and I think it's pretty redundant..
Of course if someone will request we can reconsider it
Inbal-Tish
approved these changes
Jan 14, 2021
M-i-k-e-l
added a commit
that referenced
this pull request
Jan 14, 2021
* master: (41 commits) Remove animatable from FloatingButton component (#1134) Stop using AnimatableManager in Hint (#1125) Change setTimeout's time from 50 to 100 Update generated types push expo stuff Update wiki links Fix/dialog swiping does not trigger on dialog dismissed (#1093) remove github token Create colors.md CardsScreen - fix backgrounds and remove obsolete examples (#1124) trigger build Add missing functionality for Incubator.TextField (#1121) Update all app icons sizes for iOS project Adding 'defaultSource' for image source in case of an error (#1116) DateTimePicker - adding 'headerStyle' prop to adjust iOS dialog header style (#1117) add prepush script Infra/use did update (#1119) SettingsScreen - rename to UNSAFE (#1118) Create a middleware TextField migrator to migrate people to the new TextField implementation (#1113) Fix lint error ...
M-i-k-e-l
added a commit
that referenced
this pull request
Jan 14, 2021
* master: (41 commits) Remove animatable from FloatingButton component (#1134) Stop using AnimatableManager in Hint (#1125) Change setTimeout's time from 50 to 100 Update generated types push expo stuff Update wiki links Fix/dialog swiping does not trigger on dialog dismissed (#1093) remove github token Create colors.md CardsScreen - fix backgrounds and remove obsolete examples (#1124) trigger build Add missing functionality for Incubator.TextField (#1121) Update all app icons sizes for iOS project Adding 'defaultSource' for image source in case of an error (#1116) DateTimePicker - adding 'headerStyle' prop to adjust iOS dialog header style (#1117) add prepush script Infra/use did update (#1119) SettingsScreen - rename to UNSAFE (#1118) Create a middleware TextField migrator to migrate people to the new TextField implementation (#1113) Fix lint error ...
M-i-k-e-l
added a commit
that referenced
this pull request
Jan 18, 2021
…-logic * master: update uilib-docs to v1.0.6 Read site metadata from gatsby-config gile Remove animatable from FloatingButton component (#1134) Stop using AnimatableManager in Hint (#1125) Change setTimeout's time from 50 to 100 Update generated types push expo stuff Update wiki links Fix/dialog swiping does not trigger on dialog dismissed (#1093) remove github token Create colors.md CardsScreen - fix backgrounds and remove obsolete examples (#1124) trigger build
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changelog
react-native-animatablefrom our Hint component with our own implementation