Skip to content

Stop using AnimatableManager in Hint #1125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 14, 2021
Merged

Stop using AnimatableManager in Hint #1125

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
53 changes: 31 additions & 22 deletions src/components/hint/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,8 @@
import _ from 'lodash';
import PropTypes from 'prop-types';
import React from 'react';
import {StyleSheet, AccessibilityInfo, findNodeHandle} from 'react-native';
import {View as AnimatableView} from 'react-native-animatable';
import {Typography, Spacings, Colors, BorderRadiuses, AnimatableManager} from '../../style';
import {Animated, StyleSheet, AccessibilityInfo, findNodeHandle} from 'react-native';
import {Typography, Spacings, Colors, BorderRadiuses} from '../../style';
import {Constants} from '../../helpers';
import {BaseComponent} from '../../commons';
import View from '../view';
Expand All @@ -15,7 +14,7 @@ import Modal from '../modal';
const sideTip = require('./assets/hintTipSide.png');
const middleTip = require('./assets/hintTipMiddle.png');

const DEFAULT_COLOR = Colors.blue30;
const DEFAULT_COLOR = Colors.primary;
const DEFAULT_HINT_OFFSET = Spacings.s4;
const DEFAULT_EDGE_MARGINS = Spacings.s5;
const HINT_POSITIONS = {
Expand All @@ -28,17 +27,6 @@ const TARGET_POSITIONS = {
CENTER: 'center'
};

AnimatableManager.loadAnimationDefinitions({
hintAppearDown: {
from: {opacity: 0, translateY: 20},
to: {opacity: 1, translateY: 0}
},
hintAppearUp: {
from: {opacity: 0, translateY: -20},
to: {opacity: 1, translateY: 0}
}
});

/**
* @description: Hint component for displaying a tooltip over wrapped component
* @example: https://github.com/wix/react-native-ui-lib/blob/master/demo/src/screens/componentScreens/HintsScreen.js
Expand Down Expand Up @@ -125,6 +113,17 @@ class Hint extends BaseComponent {
targetLayout: this.props.targetFrame
};

visibleAnimated = new Animated.Value(Number(!!this.props.visible))

componentDidUpdate(prevProps) {
if (prevProps.visible !== this.props.visible) {
Animated.timing(this.visibleAnimated, {
toValue: Number(!!this.props.visible),
duration: 170
}).start();
}
}

focusAccessibilityOnHint = () => {
const {message} = this.props;
const targetRefTag = findNodeHandle(this.targetRef);
Expand Down Expand Up @@ -264,6 +263,17 @@ class Hint extends BaseComponent {
return paddings;
}

getHintAnimatedStyle = () => {
const {position} = this.props;
const translateY = position === HINT_POSITIONS.TOP ? -10 : 10;
return {
opacity: this.visibleAnimated,
transform: [{
translateY: this.visibleAnimated.interpolate({inputRange: [0, 1], outputRange: [translateY, 0]})
}]
};
}

getTipPosition() {
const {position} = this.getThemeProps();
const tipPositionStyle = {};
Expand Down Expand Up @@ -343,19 +353,18 @@ class Hint extends BaseComponent {
}

renderHint() {
const {position, message, messageStyle, icon, iconStyle, borderRadius, color, testID} = this.getThemeProps();
const shownUp = position === HINT_POSITIONS.TOP;
const {message, messageStyle, icon, iconStyle, borderRadius, color, testID} = this.getThemeProps();

if (this.showHint) {
return (
<AnimatableView
animation={shownUp ? AnimatableManager.animations.hintAppearUp : AnimatableManager.animations.hintAppearDown}
duration={200}
<View
animated
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how do you control the type of animation to apply on the View?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you mean?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it. getHintAnimatedStyle

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The default one.
Users won't be able to configure it now.
I don't thing people were aware of that and I think it's pretty redundant..
Of course if someone will request we can reconsider it

style={[
{width: this.containerWidth},
styles.animatedContainer,
this.getHintPosition(),
this.getHintPadding()
this.getHintPadding(),
this.getHintAnimatedStyle()
]}
pointerEvents="box-none"
testID={testID}
Expand All @@ -371,7 +380,7 @@ class Hint extends BaseComponent {
{icon && <Image source={icon} style={[styles.icon, iconStyle]}/>}
<Text style={[styles.hintMessage, messageStyle]}>{message}</Text>
</View>
</AnimatableView>
</View>
);
}
}
Expand Down