Add accessibility props to avatar component #1155
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
M-i-k-e-l
reviewed
Jan 26, 2021
src/components/avatar/index.tsx
Outdated
| @@ -136,7 +137,7 @@ export type AvatarProps = { | |||
| * Used as a testing identifier | |||
| */ | |||
| testID?: string; | |||
| }; | |||
| } & AccessibilityProps; | |||
There was a problem hiding this comment.
- Do you need them all? Perhaps you can Pick the way we do in Dialog?
- Either way, it should be at the start (
export type AvatarProps = AccessibilityProps & {).
|
@Dor256 |
Dor256
force-pushed
the
avatar-accessibility
branch
from
30db2a5 to
59a9be7
Compare
Dor256
force-pushed
the
avatar-accessibility
branch
from
59a9be7 to
f1af5c5
Compare
M-i-k-e-l
approved these changes
Jan 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add missing accessibility typing to
Avatarcomponent.Changelog
Fix accessibility typings to
Avatarcomponent