Skip to content

Add accessibility props to avatar component #1155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 27, 2021
Merged

Add accessibility props to avatar component #1155

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f1af5c5
Add accessibility props to avatar component
Dor256 Jan 26, 2021
e7f70aa
Merge branch 'master' into avatar-accessibility
M-i-k-e-l Jan 27, 2021
b9a9e71
Merge branch 'master' into avatar-accessibility
M-i-k-e-l Jan 27, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/components/avatar/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,8 @@ import {
TouchableOpacity,
ImagePropsBase,
ImageStyle,
TextStyle
TextStyle,
AccessibilityProps
} from 'react-native';
import {Colors} from '../../style';
import {forwardRef, asBaseComponent} from '../../commons/new';
Expand Down Expand Up @@ -43,7 +44,7 @@ export enum BadgePosition {

const DEFAULT_BADGE_SIZE = 'pimpleBig';

export type AvatarProps = {
export type AvatarProps = Pick<AccessibilityProps, 'accessibilityLabel'> & {
/**
* Adds fade in animation when Avatar image loads
*/
Expand Down