-
Notifications
You must be signed in to change notification settings - Fork 734
Infra - change Dialog to use reanimated 2 #1184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Infra - change Dialog to use reanimated 2 #1184
Conversation
…n, fix\add fling logic)
…is is partially needed anyway, and it's removing some code)
@M-i-k-e-l #1224 - Migrate all of the component that use Reanimated to use the new API with a fallback to the old one. This way our users can gradually migrate when they are ready. And if someone install reanimated v2 they won't get the annoying warnings. Anyway, I separated it from the dialog changes. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Keeping this for the Dialog part |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Description
Infra - change Dialog to use reanimated 2.
Note that this has
Infra/reanimated-2-part-1-refactor-dialog
set as base and notmaster
.Known issues:
Android - gestures do not work (only the animation works), this is probably because we need to add
gestureHandlerRootHOC
orGestureHandlerRootView
somewhere (I did not find the correct way to do it).Android & iOS (more visible on Android): the view is shown for a short time in the "visible location" before animating in from the "hidden location"fixed withpersistentAnimationValue
, not sure if that's the best solution.I'm not sure I've solved all the errors from migrating to v2.
Changelog
Infra - change Dialog to use reanimated 2