Skip to content

Infra - change Dialog to use reanimated 2 #1184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

M-i-k-e-l
Copy link
Collaborator

@M-i-k-e-l M-i-k-e-l commented Feb 9, 2021

Description

Infra - change Dialog to use reanimated 2.
Note that this has Infra/reanimated-2-part-1-refactor-dialog set as base and not master.
Known issues:
Android - gestures do not work (only the animation works), this is probably because we need to add gestureHandlerRootHOC or GestureHandlerRootView somewhere (I did not find the correct way to do it).
Android & iOS (more visible on Android): the view is shown for a short time in the "visible location" before animating in from the "hidden location" fixed with persistentAnimationValue, not sure if that's the best solution.
I'm not sure I've solved all the errors from migrating to v2.

Changelog

Infra - change Dialog to use reanimated 2

@ethanshar
Copy link
Collaborator

ethanshar commented Mar 13, 2021

@M-i-k-e-l
I split your PR into two
#1223 - Only migrating the demo project intro reanimated v2, the is now enough for migrating since reanimated handle gracefully the migration. But it does throw warnings.

#1224 - Migrate all of the component that use Reanimated to use the new API with a fallback to the old one. This way our users can gradually migrate when they are ready. And if someone install reanimated v2 they won't get the annoying warnings.

Anyway, I separated it from the dialog changes.
Also, I didn't handle Incubator.TabController, since we plan to deprecate it.

@stale
Copy link

stale bot commented May 13, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label May 13, 2021
@M-i-k-e-l
Copy link
Collaborator Author

Keeping this for the Dialog part

@stale stale bot removed the wontfix label May 13, 2021
@stale
Copy link

stale bot commented Jul 12, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Jul 12, 2021
@M-i-k-e-l M-i-k-e-l removed the wontfix label Jul 12, 2021
@M-i-k-e-l M-i-k-e-l closed this Aug 24, 2021
@M-i-k-e-l M-i-k-e-l deleted the Infra/reanimated-2-with-dialog-cherry-pick branch August 24, 2021 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants