Skip to content

Use reanimatedv2 API in our components #1224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 19, 2021
Merged

Use reanimatedv2 API in our components #1224

merged 3 commits into from
Mar 19, 2021

Conversation

ethanshar
Copy link
Collaborator

Description

Use reanimated v1 & v2 API in order to support both APIs and allow users to gradually migrate to reanimated v2

Changelog

Begin transition to reanimated v2 in our components, at the moment our components should work on both versions.

@ethanshar ethanshar requested a review from M-i-k-e-l March 13, 2021 15:15
@ethanshar ethanshar mentioned this pull request Mar 13, 2021
Closed
M-i-k-e-l
M-i-k-e-l reviewed Mar 15, 2021
View reviewed changes
Copy link
Collaborator

@M-i-k-e-l M-i-k-e-l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I liked the backwards compatibility with the ||!

You didn't need the change in TabBarItem (processColor etc)? I think I had a bug without it.

@ethanshar ethanshar requested a review from M-i-k-e-l March 16, 2021 14:46
@ethanshar
Copy link
Collaborator Author

You didn't need the change in TabBarItem (processColor etc)? I think I had a bug without it.

I didn't notice something weird with it. I think it worked fine

@M-i-k-e-l
Copy link
Collaborator

I didn't notice something weird with it. I think it worked fine

Maybe they fixed it, approved, not merged

@ethanshar ethanshar merged commit 73361e0 into master Mar 19, 2021
M-i-k-e-l added a commit that referenced this pull request Mar 21, 2021
@M-i-k-e-l
Merge branch 'master' into Infra/support-svg-image
2aa0f13 
* master:
  fix/connent duration prop (#1228)
  Colors - add transparent (#1234)
  fix screen UI (#1230)
  Fix exported Image static types
  Use reanimatedv2 API in our components (#1224)
  Infra/eslint v2 (#1193)
@ethanshar ethanshar deleted the feat/useReanimated2API branch July 26, 2021 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@M-i-k-e-l M-i-k-e-l M-i-k-e-l approved these changes

Assignees

@M-i-k-e-l M-i-k-e-l

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ethanshar @M-i-k-e-l