Infra/eslint v2 #1193
Merged
Infra/eslint v2 #1193
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* master: (77 commits) Button - refactor into smaller files (#1168) replace @react-native-community/picker with @react-native-picker/picker (#1063) Update generate types fix: catch undefined StatusBarManager (#1189) prop value shape deprecation lint rule (#1094) Infra/expo app fixes (#1166) Safe require blur-view dependency in Card (#1179) Update our stars count Update expo snack link with only supported platforms Export TabBarProps and fix BadgeScreen typescript errors Disable flipper Avoid passing overlayContent in CardSecion (#1187) Fix Carousel typings updating published version no-direct-import eslint rule - adding `applyAutofix` flag (#1183) Feat/image demo broken (#1173) Remove addItems from screen with fewItems Add vertical scroll to Carousel component (#1175) Fix Carousel gif Update Carousel gifs ... # Conflicts: # eslint-rules/lib/rules/typography-deprecation.js # eslint-rules/package.json # eslint-rules/tests/lib/rules/typography-deprecation.js # eslint-rules/tests/typography_deprecation.json
M-i-k-e-l
requested review from
lidord-wix
and removed request for
ethanshar
lidord-wix
reviewed
Mar 3, 2021
eslint-rules/lib/utils/debugUtils.js
Outdated
| const cleanObject = {}; | ||
| Object.keys(object).forEach(key => { | ||
| const value = object[key]; | ||
| if (value && typeof value === 'object') { |
There was a problem hiding this comment.
I think you don't have to check if the value exists before the comparison
There was a problem hiding this comment.
I think you are right, but TBH it's a copy-pasted function and I don't want to change it without testing, I'll add a TODO, and hopefully someone will test it :)
There was a problem hiding this comment.
typeof undefined is undefined, so you can safely remove it :)
lidord-wix
approved these changes
Mar 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Handling more types of imports\requires (for instance importing *).
Handling renamed components.
Our fix is not working on all the examples.
Refactor to have more and simpler to understand utils.
It's a big one, don't get too stressed over it. Try to see what you can use later from your new rule point-of-view (you'll need to edit it and improve using these utils).
Perhaps try to see if I missed something in the tests etc.
Changelog
Big refactor, support more import\require types (for instance importing *), handling renamed components, improve fix logic.