-
Notifications
You must be signed in to change notification settings - Fork 734
Feat/optional dependencies #1198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 2 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
364d32e
Create optional dependencies for safe requires
ethanshar cfddedd
Remove GestureHandlerPackage
ethanshar 8b143a4
Update src/optionalDependencies/PickerPackage.ts
ethanshar df3f5c7
Merge branch 'master' into feat/optionalDependencies
ethanshar 35212d5
Merge branch 'feat/optionalDependencies' of github.com:wix/react-nati…
ethanshar ee1fd09
Fix lint issues
ethanshar File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
declare let BlurViewPackage: any; | ||
declare let DateTimePickerPackage: any; | ||
declare let NetInfoPackage: any; | ||
declare let PickerPackage: any, CommunityPickerPackage: any; | ||
export { BlurViewPackage, DateTimePickerPackage, NetInfoPackage, PickerPackage, CommunityPickerPackage }; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
declare let BlurViewPackage: any; | ||
export default BlurViewPackage; |
2 changes: 2 additions & 0 deletions
2
generatedTypes/optionalDependencies/DateTimePickerPackage.d.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
declare let DateTimePickerPackage: any; | ||
export default DateTimePickerPackage; |
2 changes: 2 additions & 0 deletions
2
generatedTypes/optionalDependencies/GestureHandlerPackage.d.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
declare let GestureHandlerPackage: any; | ||
export default GestureHandlerPackage; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
declare let NetInfoPackage: any; | ||
export default NetInfoPackage; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
declare let PickerPackage: any, CommunityPickerPackage: any; | ||
export { PickerPackage, CommunityPickerPackage }; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
export { default as DateTimePickerPackage } from './DateTimePickerPackage'; | ||
export { default as BlurViewPackage } from './BlurViewPackage'; | ||
export { default as NetInfoPackage } from './NetInfoPackage'; | ||
export { PickerPackage, CommunityPickerPackage } from './PickerPackage'; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
let BlurViewPackage: any; | ||
try { | ||
BlurViewPackage = require('@react-native-community/blur'); | ||
} catch (error) {} | ||
|
||
export default BlurViewPackage; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
let DateTimePickerPackage: any; | ||
try { | ||
DateTimePickerPackage = require('@react-native-community/datetimepicker')?.default; | ||
} catch (error) {} | ||
|
||
export default DateTimePickerPackage; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
let NetInfoPackage: any; | ||
try { | ||
NetInfoPackage = require('@react-native-community/netinfo'); | ||
} catch (error) {} | ||
|
||
export default NetInfoPackage; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,10 @@ | ||
let PickerPackage, CommunityPickerPackage; | ||
try { | ||
PickerPackage = require('@react-native-picker/picker'); // New package | ||
} catch (error) { | ||
try { | ||
CommunityPickerPackage = require('@react-native-community/picker'); // Deprecated package | ||
} catch (error) {} | ||
} | ||
|
||
export {PickerPackage, CommunityPickerPackage}; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
export {default as DateTimePickerPackage} from './DateTimePickerPackage'; | ||
export {default as BlurViewPackage} from './BlurViewPackage'; | ||
export {default as NetInfoPackage} from './NetInfoPackage'; | ||
export {PickerPackage, CommunityPickerPackage} from './PickerPackage'; |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.