Feat/add haptics to Drawer #1266
Conversation
| @@ -123,7 +125,8 @@ export default class Swipeable extends Component<Props, StateType> { | |||
| if (!this.dragThresholdReached && x >= threshold && x < threshold + 10) { | |||
| // move item right | |||
| this.dragThresholdReached = true; | |||
| onToggleSwipeLeft({rowWidth, leftWidth, dragX: x, triggerHaptic: true}); | |||
| HapticService.triggerHaptic(HAPTIC_METHOD, 'Drawer'); | |||
| onToggleSwipeLeft({rowWidth, leftWidth, dragX: x}); | |||
There was a problem hiding this comment.
I think we should keep the haptic optional, not all users will want to use it.
There was a problem hiding this comment.
Why not get the haptic method from the HapticService, i.e. HapticMethods.impactMedium?
There was a problem hiding this comment.
I'll be able to do that only when I'll fix the HapticMethods in the HapticService as we talked about in our dev sync.
I'm waiting for this PR to be merged to do so
There was a problem hiding this comment.
Ok. Add the other PR as a dependency and we'll merge this after it.
There was a problem hiding this comment.
Is the dependency merged?
src/components/drawer/Swipeable.tsx
Outdated
|
|
||
|
|
||
| const DRAG_TOSS = 0.05; | ||
| const LEFT_TOGGLE_THRESHOLD = 0.6; | ||
| const HAPTIC_METHOD = HapticType.impactMedium; |
There was a problem hiding this comment.
Is this working? The other PR merged?
There was a problem hiding this comment.
It is not merged yet - I added a link in the description.
And yes it works, I checked it..
There was a problem hiding this comment.
If you're using HAPTIC_METHOD only once, why store it in a const?
There was a problem hiding this comment.
Also, why impactMedium is the default?
There was a problem hiding this comment.
These are the UX guidelines.
We can open it to a discussion in the future if any user will ask to change it.
There was a problem hiding this comment.
I'm asking because our private config (Drawer.config) is setting it to impactLight, so it should be the default or it should be open for user's change.
There was a problem hiding this comment.
It has updated to impactMedium, which is the default now.
Description
Add haptic feedback to the Drawer component
Jira 1201
Depending on #1277
Changelog
Add haptic feedback to the Drawer component