Add HapticType #1277
Merged
Add HapticType #1277
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mendyEdri
reviewed
May 2, 2021
| @@ -24,6 +24,6 @@ function triggerHaptic(hapticMethod: string, componentName: string) { | |||
| } | |||
|
|
|||
| export default { | |||
| HapticMethods, | |||
| HapticType, | |||
There was a problem hiding this comment.
Nope, it's a new code so it's not in use yet :)
mendyEdri
reviewed
May 2, 2021
src/services/HapticService.ts
Outdated
|
|
||
| function triggerHaptic(hapticMethod: string, componentName: string) { | ||
| function triggerHaptic(hapticMethod: HapticType, componentName: string) { |
There was a problem hiding this comment.
It's intentionally kept its name method where all other places has changed to type?
There was a problem hiding this comment.
It was intentional, but on second thought it is better to be aligned with our 'old' code in the private repo.
mendyEdri
approved these changes
May 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Export enum HapticType instead of hapticMethods
Changelog
Export enum HapticType instead of hapticMethods