Skip to content

Typescript/StackAggregator #1299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from
Closed

Conversation

cheloveq
Copy link
Contributor

Description

Migrated StackAggregator to TS.

Changelog

Removed manual StackAggregator typings.

@cheloveq cheloveq marked this pull request as ready for review May 31, 2021 08:05
@cheloveq cheloveq requested review from ethanshar and M-i-k-e-l June 9, 2021 07:49
@ethanshar
Copy link
Collaborator

Hi @cheloveq
We weren't aware of this PR and @mendyEdri already worked on a different PR for migrating StackAggregator to typescript.
It's already been merged -> #1339

@cheloveq
Copy link
Contributor Author

cheloveq commented Jun 9, 2021

Damn, my bad. Ok, I'll open a separate PR with update of node version in your .nvmrc . It was last updated 4 years ago (v8.1.3)!

@cheloveq cheloveq closed this Jun 9, 2021
@ethanshar
Copy link
Collaborator

ethanshar commented Jun 9, 2021

👍
Just make sure to assign on me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants