Typescript/stack aggregator #1339
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Inbal-Tish
reviewed
Jun 3, 2021
| /** | ||
| * A callback for collapse state will change (value is future collapsed state) | ||
| */ | ||
| onCollapseWillChange: PropTypes.func, | ||
| onCollapseWillChange?: (change: boolean) => void; |
There was a problem hiding this comment.
'changed' instead of 'change' (as 'change' refers to the change itself and not its state)
Inbal-Tish
reviewed
Jun 3, 2021
| onCollapseChanged: PropTypes.func, | ||
| * A callback for collapse state change (value is collapsed state) | ||
| */ | ||
| onCollapseChanged?: (change: boolean) => void; |
Inbal-Tish
reviewed
Jun 3, 2021
| class StackAggregator extends PureComponent<StackAggregatorProps, State> { | ||
| static displayName = 'StackAggregator'; | ||
|
|
||
| animatedScale: any; |
There was a problem hiding this comment.
why type 'any' and not 'Animated.Value' on all the animated variables?
Inbal-Tish
approved these changes
Jun 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Migrate
StackAggregatorcomponent into typescript.Changelog
Migrate
StackAggregatorcomponent into typescript.