DateTimePicker - Implement themeVariant prop #1357
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| /** | ||
| * Override system theme variant (dark or light mode) used by the date picker. | ||
| */ | ||
| themeVariant: PropTypes.oneOf(Object.values(THEME_VARIANTS)) |
There was a problem hiding this comment.
This is a required prop? Can it be an optional one?
There was a problem hiding this comment.
This is a required prop? Can it be an optional one?
It is optional. Required would be themeVariant: PropTypes.oneOf(Object.values(THEME_VARIANTS)).isRequired
ethanshar
approved these changes
Jul 4, 2021
M-i-k-e-l
added a commit
that referenced
this pull request
Jul 13, 2021
* master: Upgrade eslint-plugin-uilib to version 2.0.09 Typescript/wizard move to typescript (#1390) Feat/hint add props (#1399) Separate radioGroup and radioButton to fix their packages (#1388) Typescript/connection status bar (#1384) Fix typescript migration bug, code should enter here to calcylate tip position also when width is undefined (casting to 0) (#1396) Fix an exception with hard coded color rule (#1394) Add onChange to dependency array (#1391) fix colorPicker ts error Update stale.yml Typescript/general missing typings (#1389) fix hint animation (#1363) using renderInput instead renderExpandableInput was left out (#1386) DateTimePicker - Implement theme variant prop (#1357) Infra/Migrate Incubator.WheelPicker to reanimated 2 (#1379) Remove old typings that were migrated to generatedTypes Fix Hint export in generatedType/index Update react-native-gesture-handler to version 1.10.3 Fix export of AvatarHelper in src/index.ts (#1376) ExampleScreenPresenter - fix typo (#1374)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
DateTimePickerrenders white on white text when Dark theme is enabled on iOS device.react-native-datetimepickerhas an override prop for this calledthemeVariant. This change is to Implement this prop inreact-native-ui-libDateTimePicker.Changelog
Add
themeVariantprop toDateTimePicker.