fix hint animation #1363
Merged
fix hint animation #1363
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ethanshar
reviewed
Jun 20, 2021
ethanshar
reviewed
Jun 21, 2021
There was a problem hiding this comment.
@mendyEdri
Android doesn't throw an error now, but also doesn't work.
See video
Also, check my comment, I don't think that's the right fix (:
Screen.Recording.2021-06-21.at.8.09.46.mov
ethanshar
reviewed
Jun 28, 2021
src/components/hint/index.tsx
Outdated
| if (!visible) { | ||
| const {onBackgroundPress, testID} = this.props; | ||
| if (!this.props.visible && this.state.animationEnded) { | ||
| console.log('removed'); |
There was a problem hiding this comment.
You forgot a console.log (:
src/components/hint/index.tsx
Outdated
Comment on lines
194
to
199
| this.setState({animationEnded: true}, () => { | ||
| setTimeout(() => { | ||
| this.setState({animationEnded: false}); | ||
| }, this.animationDuration); | ||
| }); | ||
| }; |
There was a problem hiding this comment.
This forces us to trigger two setState calls every time we trigger the animation. twice on enter twice on exit.
Maybe we can reduce that..
If you think about it, while the Hint is visible it doesn't matter really what's the value of animationEnded state.
What if instead of keeping animationEnded you'll keep something else, like actuallyVisible, hasUnmounted (or anything with a better name (: )
Then you'll update it once on enter and once on exit...
ethanshar
approved these changes
Jul 4, 2021
M-i-k-e-l
added a commit
that referenced
this pull request
Jul 13, 2021
* master: Upgrade eslint-plugin-uilib to version 2.0.09 Typescript/wizard move to typescript (#1390) Feat/hint add props (#1399) Separate radioGroup and radioButton to fix their packages (#1388) Typescript/connection status bar (#1384) Fix typescript migration bug, code should enter here to calcylate tip position also when width is undefined (casting to 0) (#1396) Fix an exception with hard coded color rule (#1394) Add onChange to dependency array (#1391) fix colorPicker ts error Update stale.yml Typescript/general missing typings (#1389) fix hint animation (#1363) using renderInput instead renderExpandableInput was left out (#1386) DateTimePicker - Implement theme variant prop (#1357) Infra/Migrate Incubator.WheelPicker to reanimated 2 (#1379) Remove old typings that were migrated to generatedTypes Fix Hint export in generatedType/index Update react-native-gesture-handler to version 1.10.3 Fix export of AvatarHelper in src/index.ts (#1376) ExampleScreenPresenter - fix typo (#1374)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix missing Hint bubble fade-out animation
Changelog
Added missing hide animation for
Hintbubble