Skip to content

Add statics to forwardRef #1475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 3, 2021
Merged

Add statics to forwardRef #1475

merged 3 commits into from
Sep 3, 2021

Conversation

M-i-k-e-l
Copy link
Collaborator

@M-i-k-e-l M-i-k-e-l commented Aug 17, 2021 •
edited
Loading

Description

Add statics to forwardRef.
This will allow us to use useImperativeHandle and have the methods autocomplete; need to do something like:

export default forwardRef<Props, Statics>(MyComponent);

Does not work with typeof.

Changelog

Add statics to forwardRef

@M-i-k-e-l M-i-k-e-l requested a review from ethanshar August 17, 2021 15:59
@M-i-k-e-l M-i-k-e-l marked this pull request as draft August 18, 2021 06:55
@M-i-k-e-l
Merge branch 'master' into feat/add-statics-to-forward-ref
8586e3f 
* master:
  Revert "Typescript/keyboard (#1449)" (#1476)
  Typescript/keyboard (#1449)
  Update generated types
  Improve GridView screen and add containerProps prop to GridListItem
@M-i-k-e-l M-i-k-e-l marked this pull request as ready for review August 18, 2021 12:40
@M-i-k-e-l M-i-k-e-l mentioned this pull request Aug 18, 2021
Merged
@ethanshar ethanshar merged commit de2eab0 into master Sep 3, 2021
@M-i-k-e-l M-i-k-e-l deleted the feat/add-statics-to-forward-ref branch September 3, 2021 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ethanshar ethanshar ethanshar approved these changes

Assignees

@ethanshar ethanshar

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@M-i-k-e-l @ethanshar