Skip to content

disable scroll for less than 1 pixel #1799

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

avishain
Copy link
Contributor

Description

should prevent situations where a friction of pixel enables scroll and hence causes the scrollview-fader appear with no reason

should prevent situations where a friction of pixel enables scroll and hence causes the scrollview-fader appear with no reason
@M-i-k-e-l
Copy link
Collaborator

Hi @D10S60948,
Thanks for your contribution, however the 1 pixel is very arbitrary IMO, moreover I'm not sure this is the place for the fix.
Could you please provide a link to a code where it breaks or even better a minimal snippet or a repro in our demo app?

@avishain
Copy link
Contributor Author

It's hard to reproduce. It happened inside the ActionSheet in very specific situation and only after the first render (after component was re-rendered it was fine).
Since it doesn't happen any more I will close this issue for now. If it will happen again I'll reopen.
Thank you.

@avishain avishain closed this Jan 25, 2022
@M-i-k-e-l M-i-k-e-l deleted the scroll-enabler branch January 25, 2022 08:50
@avishain avishain restored the scroll-enabler branch April 12, 2022 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants