Skip to content

not enable scroll if content is less than 1 pixel than it container #1972

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 24, 2022
Merged

not enable scroll if content is less than 1 pixel than it container #1972

merged 2 commits into from
Apr 24, 2022

Conversation

avishain
Copy link
Contributor

Description

should prevent situations where a friction of pixel enables scroll and hence causes the scrollview-fader appear for no reason

Example

Screen Shot 2022-04-12 at 15 19 54

@ethanshar ethanshar requested a review from M-i-k-e-l April 12, 2022 13:27
@M-i-k-e-l
Copy link
Collaborator

Hi @avishain,
You could have simply re-opened #1799

From what we've discussed this is still not reproducible in dev. Does it happen 100% of the time with a release version of your module? If yes, did you try to create a version with this change and it solved your issue?

@avishain
Copy link
Contributor Author

avishain commented Apr 14, 2022 •
edited
Loading

If yes, did you try to create a version with this change and it solved your issue?

Hi @M-i-k-e-l,
Not sure how can I create a version with this change. If I'll change it in my node_modules it won't matter as it will be built based on the version in engine. And I can't cook-book with Poco as it's in the open Wix repo + not sure how to create a build-version for it

@M-i-k-e-l
Copy link
Collaborator

Hi @M-i-k-e-l, Not sure how can I create a version with this change. If I'll change it in my node_modules it won't matter as it will be built based on the version in engine. And I can't cook-book with Poco as it's in the open Wix repo + not sure how to create a build-version for it

I'm creating a private version that uses this branch, I'll PM you when it's ready.

@avishain
Copy link
Contributor Author

The private version with the fix was QA'd and looks good

avishain added 2 commits April 24, 2022 12:16
@avishain
disable scroll for less than 1 pixel
5f979c1 
should prevent situations where a friction of pixel enables scroll and hence causes the scrollview-fader appear with no reason
@avishain
change methodology to use Math.floor
0c08976
@M-i-k-e-l M-i-k-e-l merged commit e81128a into master Apr 24, 2022
@M-i-k-e-l M-i-k-e-l deleted the scroll-enabler branch April 24, 2022 09:32
lidord-wix pushed a commit that referenced this pull request Apr 24, 2022
@avishain @lidord-wix
not enable scroll if content is less than 1 pixel than it container (#…
c555fd3 
…1972)

* disable scroll for less than 1 pixel

should prevent situations where a friction of pixel enables scroll and hence causes the scrollview-fader appear with no reason

* change methodology to use Math.floor
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@M-i-k-e-l M-i-k-e-l M-i-k-e-l approved these changes

Assignees

@M-i-k-e-l M-i-k-e-l

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@avishain @M-i-k-e-l