Infra/generify faded scroll view #1842
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lidord-wix
reviewed
Feb 15, 2022
| const FADER_SIZE = 76; | ||
| interface Statics { | ||
| scrollTo( | ||
| y?: number | {x?: number | undefined; y?: number | undefined; animated?: boolean | undefined}, |
There was a problem hiding this comment.
Looks like the types are not in the right place here
There was a problem hiding this comment.
Not sure what you mean, can you elaborate \ rephrase?
There was a problem hiding this comment.
Can the y key get both number and object?
Comment on lines
76
to
77
| const showStart = (showStartFader && scrollEnabled && !isScrollAtStart) ?? false; | ||
| const showEnd = (showEndFader && scrollEnabled && !isScrollAtEnd) ?? false; |
There was a problem hiding this comment.
Why do you need the ?? false in these two lines?
There was a problem hiding this comment.
The default for the Fader is to be visible, I want it to not be visible unless it's needed.
lidord-wix
approved these changes
Feb 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
FadedScrollView - make more generic (I will use this in
Incubator.Dialog, splitting up in to a few PRs).Look at each commit separately for convenience.
Changelog
None