fix: TextField defaultValue change #2388
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lidord-wix
reviewed
Dec 25, 2022
Sorry, forgot to mention that it happens on web. |
lidord-wix
reviewed
Dec 29, 2022
| renderTree.getByDisplayValue('someValue'); | ||
| }); | ||
|
|
||
| it('on web should reset defaultValue when prop changed after first render', () => { |
There was a problem hiding this comment.
I suggest adding the same test without setting Constants.isWeb to true since the same behavior should also apply on mobile
Co-authored-by: Lidor Dafna <[email protected]>
lidord-wix
approved these changes
Jan 1, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently when trying to change default value then it is not rendered.
This PR will fix this issue.
Changelog
TextField - fix defaultValue not changing