Skip to content

fix: TextField defaultValue change #2388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jan 1, 2023
Merged

fix: TextField defaultValue change #2388

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
9441925
fix: TextField defaultValue change
AmitShwarts Dec 22, 2022
6982eb9
fix test
AmitShwarts Dec 22, 2022
1cfe897
update webDemo to demonstrate text field default value
AmitShwarts Dec 25, 2022
c0076d8
code review + add tests
AmitShwarts Dec 26, 2022
12f3c85
Merge branch 'master' into fix/text-field-default-value-change
lidord-wix Dec 29, 2022
1c3f8b3
Update webDemo/package.json
AmitShwarts Dec 29, 2022
04fac48
fix demo & and tests
AmitShwarts Dec 29, 2022
c547f0d
fix lint
AmitShwarts Dec 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/incubator/TextField/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,6 +148,7 @@ const TextField = (props: InternalTextFieldProps) => {
onChangeText={onChangeText}
placeholder={placeholder}
hint={hint}
value={fieldState.value}
/>
)}
</View>
Expand Down
15 changes: 14 additions & 1 deletion src/incubator/TextField/useFieldState.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,11 +13,24 @@ export default function useFieldState({
onChangeValidity,
...props
}: FieldStateProps) {
const [value, setValue] = useState(props.value);
const [value, setValue] = useState(props.value ?? props.defaultValue);
const [isFocused, setIsFocused] = useState(false);
const [isValid, setIsValid] = useState<boolean | undefined>(undefined);
const [failingValidatorIndex, setFailingValidatorIndex] = useState<number | undefined>(undefined);

useEffect(() => {
if (!props.value && props.defaultValue && props.defaultValue !== value) {
setValue(props.defaultValue);

if (validateOnChange) {
validateField(props.defaultValue);
}
}

/* On purpose listen only to props.defaultValue change */
/* eslint-disable-next-line react-hooks/exhaustive-deps*/
}, [props.defaultValue, validateOnChange]);

useEffect(() => {
if (validateOnStart) {
validateField();
Expand Down