Skip to content

Incubator.Dialog - fix test (add mocks) #2551

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 13, 2023
Merged

Incubator.Dialog - fix test (add mocks) #2551

merged 2 commits into from
Apr 13, 2023

Conversation

M-i-k-e-l
Copy link
Collaborator

@M-i-k-e-l M-i-k-e-l commented Apr 4, 2023 •
edited
Loading

Description

There is some awkward code in this PR, but after talking with Niryo, this is what we're doing in the private mocks.

Changelog

None

@M-i-k-e-l M-i-k-e-l requested review from Niryo and Inbal-Tish April 4, 2023 10:20
@M-i-k-e-l M-i-k-e-l removed the request for review from Niryo April 4, 2023 12:37
@Inbal-Tish
Copy link
Collaborator

@M-i-k-e-l This is crazy! where did you find this solution??

@Inbal-Tish Inbal-Tish merged commit 22b951e into master Apr 13, 2023
@M-i-k-e-l
Copy link
Collaborator Author

@M-i-k-e-l This is crazy! where did you find this solution??

Stole some from NirYo (private mocks) and added onto it.
We got some feedback in private, so we might need to adjust it here as well, not sure yet.

@M-i-k-e-l M-i-k-e-l deleted the infra/incubator-dialog-fix-test branch April 13, 2023 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Inbal-Tish Inbal-Tish Inbal-Tish approved these changes

Assignees

@Inbal-Tish Inbal-Tish

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@M-i-k-e-l @Inbal-Tish