Skip to content

Incubator.Dialog - fix test (add mocks) #2551

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 13, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
67 changes: 67 additions & 0 deletions GestureDetectorMock.tsx
Original file line number Diff line number Diff line change
@@ -0,0 +1,67 @@
import React from 'react';
import {TouchableOpacity} from 'react-native';

type Props = {
gesture: any;
children: any;
};

export class GestureDetectorMock extends React.Component<Props> {
render() {
switch (this.props.gesture.type) {
case 'tap':
return (
<TouchableOpacity
onPress={() => {
this.props.gesture._handlers.onTouchesDown();
this.props.gesture._handlers.onEnd();
this.props.gesture._handlers.onFinalize();
}}
>
{this.props.children}
</TouchableOpacity>
);
case 'pan':
return (
<TouchableOpacity
onPress={() => {
this.props.gesture._handlers.onStart({
absoluteX: 0,
absoluteY: 0,
translationX: 0,
translationY: 0,
velocityX: 0,
velocityY: 0,
x: 0,
y: 0
});
this.props.gesture._handlers.onUpdate({
absoluteX: 0,
absoluteY: 0,
translationX: 0,
translationY: 0,
velocityX: 0,
velocityY: 0,
x: 0,
y: 0
});
this.props.gesture._handlers.onEnd({
absoluteX: 0,
absoluteY: 0,
translationX: 0,
translationY: 0,
velocityX: 0,
velocityY: 0,
x: 0,
y: 0
});
}}
>
{this.props.children}
</TouchableOpacity>
);
default:
throw new Error(`Unhandled gesture of type: ${this.props.gesture.type}`);
}
}
}
48 changes: 47 additions & 1 deletion jest-setup.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,21 @@
import {NativeModules, AccessibilityInfo, Animated} from 'react-native';
// ========= Mock Object.defineProperty to always allow overriding =========
const originalDefineProperty = Object.defineProperty;
Object.defineProperty = (obj, prop, desc) => {
try {
return originalDefineProperty(obj, prop, {...desc, configurable: true});
} catch (e) {
return originalDefineProperty(obj, prop, desc);
}
};
Object.defineProperties = (obj, props) => {
Object.keys(props).forEach(key => {
Object.defineProperty(obj, key, props[key]);
});
return obj;
};
// =========================================================================

global._UILIB_TESTING = true;

NativeModules.StatusBarManager = {getHeight: jest.fn()};
Expand All @@ -21,6 +38,26 @@ jest.mock('react-native-gesture-handler',
() => {
jest.requireActual('react-native-gesture-handler/jestSetup');
const GestureHandler = jest.requireActual('react-native-gesture-handler');
GestureHandler.Gesture.Tap = () => {
const TapMock = {
_handlers: {}
};

const getDefaultMockedHandler = handlerName => handler => {
if (typeof handler === 'function') {
TapMock._handlers[handlerName] = handler;
}
return TapMock;
};

TapMock.type = 'tap';
TapMock.maxDuration = getDefaultMockedHandler('maxDuration');
TapMock.onEnd = getDefaultMockedHandler('onEnd');
TapMock.onFinalize = getDefaultMockedHandler('onFinalize');
TapMock.onTouchesDown = getDefaultMockedHandler('onTouchesDown');
return TapMock;
};

GestureHandler.Gesture.Pan = () => {
const PanMock = {
_handlers: {}
Expand All @@ -33,13 +70,22 @@ jest.mock('react-native-gesture-handler',
return PanMock;
};

PanMock.type = 'pan';
PanMock.onStart = getDefaultMockedHandler('onStart');
PanMock.onUpdate = getDefaultMockedHandler('onUpdate');
PanMock.onEnd = getDefaultMockedHandler('onEnd');
PanMock.prepare = jest.fn();
PanMock.initialize = jest.fn();
PanMock.toGestureArray = jest.fn(() => {
return [PanMock];
});
return PanMock;
};

try {
Object.defineProperty(GestureHandler, 'GestureDetector', {
value: require('./GestureDetectorMock').GestureDetectorMock
});
} catch {}
return GestureHandler;
},
{virtual: true});
Expand Down
18 changes: 9 additions & 9 deletions src/incubator/Dialog/__tests__/index.spec.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import React, {useCallback, useEffect, useState} from 'react';
import Button from '../../../components/button';
import View from '../../../components/view';
import Dialog from '../index';
import {/* ButtonDriver, */ComponentDriver} from '../../../testkit';
import {ButtonDriver, ComponentDriver} from '../../../testkit';

const onDismiss = () => {};

Expand Down Expand Up @@ -49,13 +49,13 @@ describe('Incubator.Dialog', () => {
const component = _TestCase({onDismiss});
const dialogDriver = new ComponentDriver({component, testID: 'dialog'});
expect(await dialogDriver.exists()).toBeFalsy();
// const openButtonDriver = new ButtonDriver({component, testID: 'openButton'});
// await openButtonDriver.press();
// expect(await dialogDriver.exists()).toBeTruthy();
// expect(onDismiss).toHaveBeenCalledTimes(0);
// const closeButtonDriver = new ButtonDriver({component, testID: 'closeButton'});
// await closeButtonDriver.press();
// expect(await dialogDriver.exists()).toBeFalsy();
// expect(onDismiss).toHaveBeenCalledTimes(1);
const openButtonDriver = new ButtonDriver({component, testID: 'openButton'});
await openButtonDriver.press();
expect(await dialogDriver.exists()).toBeTruthy();
expect(onDismiss).toHaveBeenCalledTimes(0);
const closeButtonDriver = new ButtonDriver({component, testID: 'closeButton'});
await closeButtonDriver.press();
expect(await dialogDriver.exists()).toBeFalsy();
expect(onDismiss).toHaveBeenCalledTimes(1);
});
});