fix: Allow empty strings for email and number validation in validators.ts #2811
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tring Fixes/validator allow emty string
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
brianangulo
approved these changes
Mar 20, 2024
|
Thank you! @Inbal-Tish @adids1221 could you please take a peek whenever able 🙏 ? This one has been open for a few months now |
adids1221
reviewed
Mar 21, 2024
Co-authored-by: Adi Mordo <[email protected]>
adids1221
reviewed
Mar 21, 2024
Co-authored-by: Adi Mordo <[email protected]>
adids1221
reviewed
Mar 21, 2024
| @@ -8,9 +8,15 @@ const priceRegEx = /^[0-9]{1,9}([.][0-9]{1,2})?$/; | |||
|
|
|||
| const validators = { | |||
| required: (value = '') => !_.isEmpty(value), | |||
| email: (value = '') => new EmailValidator().isValid(value), | |||
| email: (value = '') => { | |||
There was a problem hiding this comment.
I think it could be a breaking change for other users.
I think we should add a new validation optionalEmail that will validate this case (empty string) and leave the email validator as it is.
adids1221
reviewed
Mar 21, 2024
changes are made as per the suggestion |
adids1221
approved these changes
Mar 27, 2024
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updated the
emailandnumbervalidators invalidator.tsto allow empty strings. Now, empty email and number strings are considered valid.Motivation
issue #2807
Changelog
emailvalidator logic to allow empty strings explicitly.numbervalidator logic to consider empty strings as valid.Additional info
This change ensures a more permissive validation for both email and number fields. If a field is not required, no error message will be displayed when users clear their input.
If you encounter any issues or have further suggestions, please let me know.
Results