Skip to content

fix: Allow empty strings for email and number validation in validators.ts #2811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Mar 27, 2024
Merged

fix: Allow empty strings for email and number validation in validators.ts #2811

Changes from 4 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
3a91390
fix: Allow empty strings for email & number validation
abdulbasitha Nov 16, 2023
7c0ce0b
revert: RegEx decimal
abdulbasitha Nov 16, 2023
3b6e2bf
Merge pull request #1 from abdulbasithqb/fixes/validator-allow-emty-s…
abdulbasithqb Nov 17, 2023
aaeed9b
Update src/components/textField/validators.ts
abdulbasithqb Mar 21, 2024
aa71d4a
Update src/components/textField/validators.ts
abdulbasithqb Mar 21, 2024
fc2147d
added optionalEmail to validators.ts
abdulbasithqb Mar 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions src/components/textField/validators.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,15 @@ const priceRegEx = /^[0-9]{1,9}([.][0-9]{1,2})?$/;

const validators = {
required: (value = '') => !_.isEmpty(value),
email: (value = '') => new EmailValidator().isValid(value),
email: (value = '') => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it could be a breaking change for other users.
I think we should add a new validation optionalEmail that will validate this case (empty string) and leave the email validator as it is.

// Allow empty strings
if (_.isEmpty(value)) {
return true;
}
return new EmailValidator().isValid(value);
},
url: (value = '') => urlRegEx.test(value),
number: (value = '') => integerRegEx.test(value) || decimalNumberRegEx.test(value),
number: (value = '') => integerRegEx.test(value) || decimalNumberRegEx.test(value),
price: (value = '') => priceRegEx.test(value)
};

Expand Down