Fix/wheel picker initial value on change #3029
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 2727fa1.
ethanshar
reviewed
Apr 16, 2024
src/components/WheelPicker/index.tsx
Outdated
| @@ -148,7 +148,7 @@ const WheelPicker = <T extends WheelPickerItemValue>(props: WheelPickerProps<T>) | |||
| preferredNumVisibleRows: numberOfVisibleRows | |||
| }); | |||
|
|
|||
| const prevInitialValue = useRef(initialValue); | |||
| const shouldInvokeOnChange = useRef(false); | |||
There was a problem hiding this comment.
It's better that the flag will represent the edge case and not the common case.
Meaning that false will be the usual value, so it's better to name it something like shouldSkipNextOnChange or something similar.
This way its value will be usually false and only when turning it on set it to true.
ethanshar
approved these changes
Apr 16, 2024
nitzanyiz
added a commit
that referenced
this pull request
Apr 16, 2024
* WheelPicker prevInitailValue setter changed * Revert "WheelPicker prevInitailValue setter changed" This reverts commit 2727fa1. * added handling for when a scroll is invoked by the user and not programatically * change WheelPicker Driver to invoke onScrollBeginDrag on moveToItem * changed naming * changed naming to be more explanatory * changed default skip value
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The WheelPicker was not invoking
onChangeif theinitialValuewas changed right afteronChangewas called. I added a handling for wether the drag is a user or a programatic scroll.Changelog
WheelPicker - Fix onChange not called when initial value is changed.
Additional info
MADS-4145