Skip to content

Fix/wheel picker initial value on change #3029

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Apr 16, 2024
Merged

Fix/wheel picker initial value on change #3029

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
2727fa1
WheelPicker prevInitailValue setter changed
nitzanyiz Apr 15, 2024
ef3cc85
Revert "WheelPicker prevInitailValue setter changed"
nitzanyiz Apr 15, 2024
3a41202
added handling for when a scroll is invoked by the user and not progr…
nitzanyiz Apr 16, 2024
51f9a21
change WheelPicker Driver to invoke onScrollBeginDrag on moveToItem
nitzanyiz Apr 16, 2024
2ea4fde
changed naming
nitzanyiz Apr 16, 2024
d03494f
changed naming to be more explanatory
nitzanyiz Apr 16, 2024
dbef95c
changed default skip value
nitzanyiz Apr 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/components/WheelPicker/WheelPicker.driver.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ export const WheelPickerDriver = (props: ComponentProps) => {
const itemsLength = listDriver.getElement().props.data?.length ?? 0;

const moveToItem = (index: number, itemHeight: number = ITEM_HEIGHT, numberOfRows: number = itemsLength) => {
listDriver.triggerEvent('onScrollBeginDrag');
listDriver.triggerEvent('onMomentumScrollEnd', {
contentOffset: {x: 0, y: itemHeight * index},
contentSize: {height: numberOfRows * itemHeight, width: 400},
Expand Down
19 changes: 12 additions & 7 deletions src/components/WheelPicker/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,7 +148,7 @@ const WheelPicker = <T extends WheelPickerItemValue>(props: WheelPickerProps<T>)
preferredNumVisibleRows: numberOfVisibleRows
});

const prevInitialValue = useRef(initialValue);
const shouldSkipNextOnChange = useRef(false);
const prevIndex = useRef(currentIndex);
const [flatListWidth, setFlatListWidth] = useState(0);
const keyExtractor = useCallback((item: WheelPickerItemProps<T>, index: number) => `${item}.${index}`, []);
Expand All @@ -167,18 +167,22 @@ const WheelPicker = <T extends WheelPickerItemValue>(props: WheelPickerProps<T>)

useEffect(() => {
// This effect making sure to reset index if initialValue has changed
!isUndefined(initialValue) && scrollToIndex(currentIndex, true);
if (!isUndefined(initialValue)) {
shouldSkipNextOnChange.current = true;
scrollToIndex(currentIndex, true);
}
}, [currentIndex]);

const _onChange = useCallback((value: T, index: number) => {
if (prevInitialValue.current !== initialValue) {
// don't invoke 'onChange' if 'initialValue' changed
prevInitialValue.current = initialValue;
} else {
if (!shouldSkipNextOnChange.current) {
onChange?.(value, index);
}
},
[initialValue, onChange]);
[onChange]);

const disableOnChangeSkip = useCallback(() => {
shouldSkipNextOnChange.current = false;
}, []);

const onValueChange = useCallback((event: NativeSyntheticEvent<NativeScrollEvent>) => {
const {value, index} = getRowItemAtOffset(event.nativeEvent.contentOffset.y);
Expand Down Expand Up @@ -359,6 +363,7 @@ const WheelPicker = <T extends WheelPickerItemValue>(props: WheelPickerProps<T>)
onScroll={scrollHandler}
onMomentumScrollEnd={onValueChange}
showsVerticalScrollIndicator={false}
onScrollBeginDrag={disableOnChangeSkip} // user dragged wheel.
// @ts-ignore
ref={scrollView}
// @ts-expect-error
Expand Down