Skip to content

Assets Typing #3051

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
May 6, 2024
Merged

Assets Typing #3051

merged 10 commits into from
May 6, 2024

Conversation

nitzanyiz
Copy link
Collaborator

Description

Added typing to loadAssetsGroup. The function now asserts the type of assets with the object and path passed to the function. Assets instance no longer return from loadAssetsGroup

Changelog

Assets - Typing is added to the assets instance after assets are loaded with loadAssetsGroup. Asset instance no longer returned from loadAssetsGroup.

Additional info

MADS-4126

@nitzanyiz nitzanyiz requested a review from ethanshar May 1, 2024 13:00
@nitzanyiz nitzanyiz marked this pull request as ready for review May 1, 2024 13:00
@nitzanyiz nitzanyiz marked this pull request as draft May 1, 2024 13:01
@nitzanyiz nitzanyiz marked this pull request as ready for review May 5, 2024 15:05
@ethanshar
Copy link
Collaborator

Approved. Looks good 👌
Let's see how it all integrated with private and take it from there..

@nitzanyiz nitzanyiz merged commit 83ff9a6 into master May 6, 2024
1 check passed
@nitzanyiz nitzanyiz deleted the infra/AssetsTypings branch May 6, 2024 08:05
nitzanyiz added a commit that referenced this pull request Jun 2, 2024
@nitzanyiz
Revert "Assets Typing (#3051)"
c0a3e36 
This reverts commit 83ff9a6.
nitzanyiz added a commit that referenced this pull request Jun 2, 2024
@nitzanyiz
Revert "Assets Typing (#3051)"
7d4cd7f 
This reverts commit 83ff9a6.
ethanshar pushed a commit that referenced this pull request Jun 2, 2024
@nitzanyiz
Reverting to Assets path assertion. (#3116)
d21a65f 
* Revert "handled case of assets union (#3060)"

This reverts commit 2bff5d1.

* Revert "Assets Typing (#3051)"

This reverts commit 83ff9a6.

* kepts assets typings file

* changed assets import

* changed configrations
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ethanshar ethanshar ethanshar approved these changes

Assignees

@ethanshar ethanshar

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nitzanyiz @ethanshar