handled case of assets union #3060
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moved asset types to differenct file
ethanshar
reviewed
May 7, 2024
| @@ -0,0 +1,22 @@ | |||
| type DotExtendedString<T extends string> = `${T}.`; | |||
There was a problem hiding this comment.
Ok, I reviewed this again, this time more thoroughly..
Since the TS utils are pretty complicated to understand at first glance I'd suggest to make them more readable.
- I'd change params names like
TandKto something with more meaning..
for example, maybe change thisAssetRecord<T extends string, K extends object = {}, This extends object>toAssetRecord<PATH extends string, ASSETS extends object = {}, ASSETS_CLASS extends object> - Let's add a short description above the complicated utils of what exactly they do. If we'll have to investigate an issue in the future it can be very useful
- RecRecord util's name is not so clear, can you think of a better name?
ethanshar
approved these changes
May 8, 2024
ethanshar
pushed a commit
that referenced
this pull request
Jun 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed typings when assets where loaded to an already loaded path. When loading to an already loaded path the type was overridden and not combined.
Changelog
Assets - Fix loading assets typings to preloaded path.
Additional info
MADS-4126